From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-55911-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14577 invoked by alias); 9 May 2008 06:46:24 -0000
Received: (qmail 14567 invoked by uid 22791); 9 May 2008 06:46:23 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 May 2008 06:46:04 +0000
Received: from HOME-C4E4A596F7 ([83.130.255.47]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K0L003T1A4L5WA4@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Fri, 09 May 2008 10:00:22 +0300 (IDT)
Date: Fri, 09 May 2008 12:59:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [rfc] Retrieve libraries from remote target
In-reply-to: <200805082021.m48KLu7m005089@d12av02.megacenter.de.ibm.com>
X-012-Sender: halo1@inter.net.il
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <umyn0m0uz.fsf@gnu.org>
References: <200805082021.m48KLu7m005089@d12av02.megacenter.de.ibm.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-05/txt/msg00312.txt.bz2

> Date: Thu, 8 May 2008 22:21:56 +0200 (CEST)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
> 
> The user interface is simple: if the path specified as "sysroot" starts
> with the string "remote:", the sysroot location is assumed to be on the
> remote target.

What if my _local_ "sysroot" happens to begin with the literal string
"remote:"?  How can I tell GDB this is not a remote location?

> +	  error (_("Could not open `%s' as an executable file: %s"),
> +		 temp_pathname, bfd_errmsg (bfd_get_error ()));

In other error messages, you used "..", not `..', to quote file names.
I like `..' better, and I think we use `..' in more places than we use
"..".  I think consistency is important in user messages.

> +  if (strlen (bfd_get_filename (abfd)) >= SO_NAME_MAX_PATH_SIZE)
> +    error (_("Full path name length of shared library exceeds \
> +SO_NAME_MAX_PATH_SIZE in so_list structure."));

Is this really a useful message, especially since we don't show the
actual value of SO_NAME_MAX_PATH_SIZE and the actual length of the
file name?  I say either show the two numbers explicitly, or just tell
it's too long.  (Yes, I know you only made a minor modification of an
existing message.)

Also, GNU coding standards frown on using "path name", they want us to
use "file name".  If you do that, I think you can lose the "Full"
part.

Finally, this needs documentation before it is committed.

Thanks!