From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61322-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15750 invoked by alias); 26 Jan 2009 04:02:11 -0000
Received: (qmail 15738 invoked by uid 22791); 26 Jan 2009 04:02:11 -0000
X-SWARE-Spam-Status: No, hits=0.3 required=5.0 	tests=AWL,BAYES_40,J_CHICKENPOX_37,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout2.012.net.il (HELO mtaout2.012.net.il) (84.95.2.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Jan 2009 04:02:07 +0000
Received: from conversion-daemon.i_mtaout2.012.net.il by i_mtaout2.012.net.il (HyperSendmail v2004.12) id <0KE2009008E0LT00@i_mtaout2.012.net.il> for gdb-patches@sourceware.org; Mon, 26 Jan 2009 06:02:21 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.255.234]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KE200D8P8JLH0O3@i_mtaout2.012.net.il>; Mon, 26 Jan 2009 06:02:21 +0200 (IST)
Date: Mon, 26 Jan 2009 04:02:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 4/4] catch syscall -- try 4 -- Build system, testcase and 	documentation
In-reply-to: <1232929837.26873.25.camel@miki>
To: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org, teawater@gmail.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <umydesojx.fsf@gnu.org>
References: <1232929837.26873.25.camel@miki>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-01/txt/msg00492.txt.bz2

> From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
> Cc: teawater <teawater@gmail.com>
> Date: Sun, 25 Jan 2009 22:30:36 -0200
> 
> At last but not least, the code for the build system, testcase and
> documentation parts.

Thanks.

> 2009-01-25  Sergio Durigan Junior <sergiodj@linux.vnet.ibm.com>
> 	
> 	* gdb.texinfo (catch syscall): Documentation about the new
> 	feature.

This is approved, with a few minor comments:

> +Catchpoint 1 (call to syscall 'chroot'), 0xffffe424 in __kernel_vsyscall ()

This line (and others similar to it) is too long for @smallexample, it
will certainly overflow the page margin.  Please break these long
lines in two.  The rule is to have at most 74 characters inside
@smallexample blocks.

> +If you configure @value{GDBN} using the @samp{--without-expat} option,
> +it will not be able to display syscall names.  Also, if your
> +architecture does not have an XML file describing its system calls,
> +you will not be able to see the syscall names.

It would be good to add here a sentence saying that these two features
are used for accessing the syscall name database.  It might be obvious
for you, but a Joe Random Hacker may not immediately realize that
catching syscalls has any relation to XML and expat.

What about a NEWS entry?