From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47930-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14135 invoked by alias); 6 Mar 2007 21:03:19 -0000
Received: (qmail 14127 invoked by uid 22791); 6 Mar 2007 21:03:18 -0000
X-Spam-Check-By: sourceware.org
Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 06 Mar 2007 21:03:10 +0000
Received: from HOME-C4E4A596F7 (IGLD-84-228-227-18.inter.net.il [84.228.227.18]) 	by romy.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id HHZ02540 (AUTH halo1); 	Tue, 6 Mar 2007 23:03:00 +0200 (IST)
Date: Tue, 06 Mar 2007 21:03:00 -0000
Message-Id: <ulkiam6en.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
CC: jimb@codesourcery.com, mark.kettenis@xs4all.nl, deuling@de.ibm.com,         pedro_alves@portugalmail.pt, gdb-patches@sourceware.org
In-reply-to: <20070306195211.GA18974@adacore.com> (message from Joel Brobecker 	on Tue, 6 Mar 2007 11:52:11 -0800)
Subject: Re: [Patch]: Little Cleanup
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <45E7CC17.5040304@de.ibm.com> <45E93AE5.5050704@portugalmail.pt> <ulkie62od.fsf@gnu.org> <45EBB15E.4000602@de.ibm.com> <uvehfmmfj.fsf@gnu.org> <200703052119.l25LJKVw021917@brahms.sibelius.xs4all.nl> <utzwzmlk7.fsf@gnu.org> <m3odn7gxjl.fsf@codesourcery.com> <uslcjm26g.fsf@gnu.org> <20070306195211.GA18974@adacore.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-03/txt/msg00061.txt.bz2

> Date: Tue, 6 Mar 2007 11:52:11 -0800
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: Jim Blandy <jimb@codesourcery.com>, mark.kettenis@xs4all.nl,
> 	deuling@de.ibm.com, pedro_alves@portugalmail.pt,
> 	gdb-patches@sourceware.org
> 
> Then perhaps this suggests that the function could be renamed into
> something clearer?

Fine with me.  Note that the original code had a local variable that
made this clear; this whole discussion was caused by a patch that
removed that variable.

> But otherwise, yes, I agree with Jim and Mark,
> because maintaining these comments everywhere is going to be an issue.

I never said anything about ``maintaining these comments everywhere''.
There's no need for such generalizations.