Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 2/2] Wrap-up expression support for DFP.
Date: Sat, 29 Dec 2007 11:21:00 -0000	[thread overview]
Message-ID: <ulk7dycix.fsf@gnu.org> (raw)
In-Reply-To: <1198705277.12907.39.camel@localhost.localdomain> (message from 	Thiago Jung Bauermann on Wed, 26 Dec 2007 19:41:17 -0200)

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Wed, 26 Dec 2007 19:41:17 -0200
> 
> Actually, these numbers refer to the double representation in the target
> system, not to the decimal float representation used in libdecnumber. By
> the way, since libiberty also has an implementation for asprintf, I
> could do away with these estimates and just use this function instead.
> 
> > > +  /* We cannot use snprintf here because it is defined only in C99.
> > 
> > We have portable substitutes for snprintf, I think.  Take a look at
> > libiberty, for example.
> 
> Yes, it is there. I didn't find any .h, though, so I don't really know
> the proper way to use them.

There's include/libiberty.h, where all libiberty functions are
declared, conditioned by corresponding preprocessor defines.  Those
preprocessor defines should be defined by the configure script for
platforms that don't have those functions in their native libraries.

> > > +  /* This is an ugly way to do the conversion, but libdecnumber does
> > > +     not offer a direct way to do it.  */
> > > +  decimal_to_string (from, len, buffer);
> > > +  return atof (buffer);
> > 
> > Isn't strtold better here?
> 
> It's C99 and not in libiberty.

Then how about using strtod?


  reply	other threads:[~2007-12-29 11:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-20  5:55 [patch 0/2] Complete expression support for Decimal Floating Point Thiago Jung Bauermann
2007-12-20  5:55 ` [patch 1/2] Recognize DFP types in casts Thiago Jung Bauermann
2007-12-20 15:24   ` Daniel Jacobowitz
2007-12-20 16:48     ` Thiago Jung Bauermann
2007-12-20 16:54       ` Thiago Jung Bauermann
2007-12-20 16:57       ` Daniel Jacobowitz
2007-12-20 17:21         ` Thiago Jung Bauermann
2007-12-20  8:03 ` [patch 2/2] Wrap-up expression support for DFP Thiago Jung Bauermann
2007-12-21 16:12   ` Eli Zaretskii
2007-12-21 16:30     ` Andreas Schwab
2007-12-21 16:38       ` Eli Zaretskii
2007-12-27  7:40     ` Thiago Jung Bauermann
2007-12-29 11:21       ` Eli Zaretskii [this message]
2008-01-02 20:07         ` Thiago Jung Bauermann
2008-01-05 11:30           ` Eli Zaretskii
2008-01-07 16:20             ` Thiago Jung Bauermann
2008-01-07 17:09               ` Thiago Jung Bauermann
2008-01-07 21:09               ` Eli Zaretskii
2008-01-07 22:39                 ` Thiago Jung Bauermann
2007-12-28  6:16     ` Thiago Jung Bauermann
2007-12-29 12:53       ` Eli Zaretskii
2008-01-02 16:42         ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ulk7dycix.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=bauerman@br.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox