From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61589-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27031 invoked by alias); 9 Feb 2009 20:38:25 -0000
Received: (qmail 27014 invoked by uid 22791); 9 Feb 2009 20:38:24 -0000
X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Feb 2009 20:38:15 +0000
Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KET00G00FWSSL00@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Mon, 09 Feb 2009 22:38:31 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.128.7]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KET00M1OG06D6E2@i_mtaout5.012.net.il>; Mon, 09 Feb 2009 22:38:31 +0200 (IST)
Date: Mon, 09 Feb 2009 20:38:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Use i386_use_watchpoints for go32v2, bds and windows native
In-reply-to: <000401c98a88$afe4c2c0$0fae4840$@u-strasbg.fr>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uljsfs5vs.fsf@gnu.org>
References: <000001c98a44$29b02a30$7d107e90$@u-strasbg.fr> <uprhss12h.fsf@gnu.org> <000401c98a88$afe4c2c0$0fae4840$@u-strasbg.fr>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-02/txt/msg00208.txt.bz2

> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> Cc: <gdb-patches@sourceware.org>
> Date: Mon, 9 Feb 2009 08:33:20 +0100
> 
>   The function i386_use_watchpoints
> simply sets the target vector fields related to hardware watchpoints.
>   But this change alone is useless as the mechanism used to set
> hardware watchpoints in gdb relies on macros
> called target_insert_watchpoint or target_remove_watchpoint
> (plus others), macros that are set in nm-i386.h
> to call directly i386_insert_watchpoint/i386_remove_watchpoint,
> unless the macro I386_WATCHPOINTS_IN_TARGET_VECTOR is also
> defined when parsing that header.
> 
>   If target_xxx_watchpoint are set by nm-i386.h header,
> 'target remote' or 'target extended-remote' do not
> work as expected for remote hardware watchpoints because 
> instead of calling remove_insert_watchpoint  and similar,
> which generate the Z2 to Z4 packets, it still
> calls the native i386_insert_watchpoint.

Thanks.  I'm okay with the changes to go32-nat.c and nm-go32.h.