From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24402 invoked by alias); 5 Jun 2003 09:54:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23273 invoked from network); 5 Jun 2003 09:54:07 -0000 Received: from unknown (HELO main.gmane.org) (80.91.224.249) by sources.redhat.com with SMTP; 5 Jun 2003 09:54:07 -0000 Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19NrPK-00047h-00 for ; Thu, 05 Jun 2003 11:51:42 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gdb-patches@sources.redhat.com Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19NrPH-000479-00 for ; Thu, 05 Jun 2003 11:51:39 +0200 From: Raoul Gough Subject: Re: [RFA] Add shared object relocation tests Date: Thu, 05 Jun 2003 09:54:00 -0000 Message-ID: References: <20030603130744.GB13577@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@main.gmane.org User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/20.4 (windows-nt) Cancel-Lock: sha1:8tgCyS2aJIAQknvfaHklyl8NAUg= X-SW-Source: 2003-06/txt/msg00193.txt.bz2 Raoul Gough writes: > Daniel Jacobowitz writes: [snip] >> Please just use return, not gdb_suppress_entire_file. In particular, >> using both causes the _next_ test to fail, I think. > > Hmmm.... gdb_suppress_entire_file seems to be the usual response to > testcase compilation failures, so it would probably make more sense to > remove the return statement instead. I don't really know what the pros > and cons are in this case - is there some reason to prefer the return > option (what about logging the error in that case?) OK, I managed to mess up CC'ing Daniel with my posting, but he suggested via email that I use "untested" instead of gdb_suppress_entire_file. It looks like a suitable example is in src/gdb/testsuite/gdb.java/jmisc.exp in case anyone else is interested. I'm updating shreloc.exp now, and will add the files to CVS later today, unless somebody objects in the mean time. -- Raoul Gough "Let there be one measure for wine throughout our kingdom, and one measure for ale, and one measure for corn" - Magna Carta