Re: [PATCH] remove download_write_size variable

Daniel Jacobowitz
2006-07-18T20:42:08Z

On Tue, Jul 18, 2006 at 04:48:44PM +0400, Vladimir Prus wrote:
>
> This patch removes the 'download_write_size'. At the moment, is has pretty low
> value, it's not clear why we need a separate option for just one command, and
> the new qSupported packet allows to negotiate packet size with the stub.
>
> So, I don't see any reason why this variable is needed, and given that flash
> patches will seriously change symfile.c anyway, I suggest that we
> "garbage-collect" this variable.
>
> Comments?
>
> - Volodya
>
> 2006-07-18 Vladimir Prus <vladimir@codesourcery.com>
>
> * symfile.c (download_write_size): Remove.
> (show_download_write_size): Remove.
> (load_section_callback): Don't use download_write_size.
> (_initialize_symfile): Don't register download_write_size.

I can find references to download-write-size on the Internet, e.g. in
FAQs suggesting how to get better write performance. They all seem to
push it as high as memory-write-packet-size, though, which suggests we
do not need both limits.

I think it's reasonable to remove it. However, you'll have to also
remove it from the manual (it's a documented command). And I believe
it should be added to NEWS as a removed feature.

I'm going to let this patch sit a little while, in case anyone else can
think of a reason to keep "set download-write-size".

--
Daniel Jacobowitz
CodeSourcery