From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26177 invoked by alias); 17 Nov 2007 09:13:49 -0000 Received: (qmail 26169 invoked by uid 22791); 17 Nov 2007 09:13:48 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 17 Nov 2007 09:13:45 +0000 Received: from HOME-C4E4A596F7 ([81.5.32.198]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id EDS26343 (AUTH halo1); Sat, 17 Nov 2007 11:13:35 +0200 (IST) Date: Sat, 17 Nov 2007 09:13:00 -0000 Message-Id: From: Eli Zaretskii To: Nick Roberts CC: drow@false.org, vladimir@codesourcery.com, gdb-patches@sources.redhat.com In-reply-to: <18238.3787.459206.333769@kahikatea.snap.net.nz> (message from Nick Roberts on Sat, 17 Nov 2007 10:42:35 +1300) Subject: Re: delete_breakpoint: don't try to insert other breakpoints Reply-to: Eli Zaretskii References: <200711142324.11319.vladimir@codesourcery.com> <200711161334.40641.vladimir@codesourcery.com> <20071116130250.GA31441@caradoc.them.org> <18238.3787.459206.333769@kahikatea.snap.net.nz> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00348.txt.bz2 > From: Nick Roberts > Date: Sat, 17 Nov 2007 10:42:35 +1300 > Cc: Daniel Jacobowitz , vladimir@codesourcery.com, > gdb-patches@sources.redhat.com > > > > Eli, how is code which will never be reached a feature? > > > > The code is never reached only as long as breakpoints are deleted > > synchronously (because we remove the breakpoint instruction as soon as > > the inferior stops). > > I've run the testsuite using my asynchronous version of GDB, with and > without Vladimir's change and, in fact, there was one less failure and > seven more passes with it. Notably, the extra passes with print-threads.exp > involved breakpoints. That's because we don't allow deleting breakpoints asynchronously even in the async version, AFAIK.