From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-54033-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18944 invoked by alias); 11 Feb 2008 20:01:31 -0000
Received: (qmail 18841 invoked by uid 22791); 11 Feb 2008 20:01:29 -0000
X-Spam-Check-By: sourceware.org
Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (213.8.233.22)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 11 Feb 2008 20:01:00 +0000
Received: from HOME-C4E4A596F7 (IGLD-84-229-231-35.inter.net.il [84.229.231.35]) 	by nitzan.inter.net.il (MOS 3.7.3a-GA) 	with ESMTP id JDE75010 (AUTH halo1); 	Mon, 11 Feb 2008 21:57:35 +0200 (IST)
Date: Mon, 11 Feb 2008 20:01:00 -0000
Message-Id: <uk5lbp8l4.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Markus Deuling <deuling@de.ibm.com>
CC: gdb-patches@sourceware.org, drow@false.org, uweigand@de.ibm.com,         muller@ics.u-strasbg.fr
In-reply-to: <47B00041.2030800@de.ibm.com> (message from Markus Deuling on 	Mon, 11 Feb 2008 08:58:57 +0100)
Subject: Re: [Patch]: Build script gdb_buildall.sh
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <47B00041.2030800@de.ibm.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-02/txt/msg00179.txt.bz2

> Date: Mon, 11 Feb 2008 08:58:57 +0100
> From: Markus Deuling <deuling@de.ibm.com>
> CC: Eli Zaretskii <eliz@gnu.org>, Daniel Jacobowitz <drow@false.org>,
>         Ulrich Weigand <uweigand@de.ibm.com>,
>         Pierre Muller <muller@ics.u-strasbg.fr>
> 
> this patch adds documentation to this patch: http://sourceware.org/ml/gdb-patches/2008-01/msg00671.html. 
> 
> 
> ChangeLog:
> 
> 	
> 	Add script to build and test GDB using enable-targets=all.
> 
> 	* gdb_buildall.sh: New file.
> 
> 
> 
> ChangeLog Doc:
> 
> 	* gdbint.texinfo (Build Script): New section. Mention new build script
> 	gdb_buildall.sh.
> 
> 
> Eli, is the documentation ok? I added a section to "Hints" in gdbint.texinfo.

Yes, except for a few minor gotchas:

> +The script @code{gdb_buildall.sh} builds GDB with flag

gdb_buildall.sh is a file, so please use the @file markup, not @code.

> +@code{--enable-targets=all} set. This builds GDB with all supported targets

Options such as --enable-targets=all should have the @option markup.

> +activated. This helps testing GDB when doing changes that affect more than one
            ^^
Two spaces after a period that ends a sentence.

> +After building GDB the scripts checks which architectures are supported and

We use @value{GDBN} instead of a literal GDB, to allow changing the
name by editing a single line at the beginning of the manual.

Thanks.