From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-62317-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16207 invoked by alias); 21 Mar 2009 08:03:20 -0000
Received: (qmail 16198 invoked by uid 22791); 21 Mar 2009 08:03:19 -0000
X-SWARE-Spam-Status: No, hits=-0.0 required=5.0 	tests=AWL,BAYES_05,J_CHICKENPOX_55,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 21 Mar 2009 08:03:13 +0000
Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KGU00J00IGQ9V00@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Sat, 21 Mar 2009 10:03:10 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.127.23.114]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KGU00AD0JP8L140@i-mtaout7.012.net.il>; Sat, 21 Mar 2009 10:03:09 +0200 (IST)
Date: Sat, 21 Mar 2009 08:34:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [rfc] python API exposing inferior's frame stack.
In-reply-to: <1237587320.6897.20.camel@localhost.localdomain>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uk56jpaki.fsf@gnu.org>
References: <1236706351.11106.17.camel@localhost.localdomain> <ubps9kw6u.fsf@gnu.org> <1237133466.316.16.camel@localhost.localdomain> <ur60yr3rw.fsf@gnu.org> <1237160806.8098.8.camel@localhost.localdomain> <uprgiqfqz.fsf@gnu.org> <1237587320.6897.20.camel@localhost.localdomain>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-03/txt/msg00427.txt.bz2

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Fri, 20 Mar 2009 19:15:20 -0300
> 
> So I am changing the documentation and doc strings for Frame.older and
> Frame.newer to use similar wording:
> 
> +@defmethod Frame older
> +Return the frame that called this frame.
> +@end defmethod
> +
> +@defmethod Frame newer
> +Return the frame called by this frame.
> +@end defmethod
> 
> I also changed Frame.unwind_stop_reason to use "outermost":
> 
> +@defmethod Frame unwind_stop_reason
> +Return an integer representing the reason why it's not possible to find
> +more frames toward the outermost frame.  Use
> +@code{gdb.frame_stop_reason_string} to convert the value returned by this
> +function to a string.
> +@end defmethod
> 
> What do you think?

That's fine, thanks.

One comment:

> +@defmethod Frame equals frame
> +Compare frames.
> +@end defmethod

I see from the code that this return a boolean yes/no value (as
opposed to also providing some idea about the order, like strcmp in
C).  So perhaps "compare frames" might mislead someone.