From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24964 invoked by alias); 29 Feb 2004 06:10:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24955 invoked from network); 29 Feb 2004 06:10:20 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 29 Feb 2004 06:10:20 -0000 Received: from [207.232.27.5] (helo=WST0054) by monty-python.gnu.org with asmtp (Exim 4.30) id 1AxK8b-0001FT-OM; Sun, 29 Feb 2004 01:09:19 -0500 Date: Sun, 29 Feb 2004 06:10:00 -0000 Message-Id: From: Eli Zaretskii To: Andrew Cagney CC: kettenis@chello.nl, gdb-patches@sources.redhat.com In-reply-to: <4040C019.6090601@gnu.org> (message from Andrew Cagney on Sat, 28 Feb 2004 11:21:45 -0500) Subject: Re: [PATCH] Fix compilation of tui/tui.c Reply-to: Eli Zaretskii References: <200402281503.i1SF3p8g011820@elgar.kettenis.dyndns.org> <4040B1D7.4090805@gnu.org> <200402281547.i1SFlv87012449@elgar.kettenis.dyndns.org> <4040C019.6090601@gnu.org> X-SW-Source: 2004-02/txt/msg00884.txt.bz2 > Date: Sat, 28 Feb 2004 11:21:45 -0500 > From: Andrew Cagney > > > Is there a reason for changing "" to <>, it breaks some of GDB's > > scripts. > > > > I changed because we seem to use <> everywhere else in GDB for the > > readline includes, e.g. event-top.c, completer.c. I think it's good > > to be consistent; you get less surprises that way. > > I'll change them so that they are consistent. gdb_makefile.sh: > http://sources.redhat.com/gdb/current/ari/gdb_makefile.sh > knows about "..." includes. Andrew, how about saying this somewhere in the coding standards description? I, for one, was unaware of the special importance of "...", and I presume Mark didn't know that as well.