From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-43016-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16760 invoked by alias); 24 Feb 2006 07:53:14 -0000
Received: (qmail 16751 invoked by uid 22791); 24 Feb 2006 07:53:13 -0000
X-Spam-Check-By: sourceware.org
Received: from gandalf.inter.net.il (HELO gandalf.inter.net.il) (192.114.186.17)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Feb 2006 07:53:11 +0000
Received: from nitzan.inter.net.il (nitzan.inter.net.il [192.114.186.20]) 	by gandalf.inter.net.il (MOS 3.7.1-GA) 	with ESMTP id HYV05413; 	Fri, 24 Feb 2006 09:51:52 +0200 (IST)
Received: from HOME-C4E4A596F7 (IGLD-83-130-198-86.inter.net.il [83.130.198.86]) 	by nitzan.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id CTU42383 (AUTH halo1); 	Fri, 24 Feb 2006 09:51:49 +0200 (IST)
Date: Fri, 24 Feb 2006 07:53:00 -0000
Message-Id: <uirr59otf.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Jason Kraftcheck <kraftche@cae.wisc.edu>
CC: drow@false.org, gdb-patches@sources.redhat.com
In-reply-to: <43FE336D.1010502@cae.wisc.edu> (message from Jason Kraftcheck on 	Thu, 23 Feb 2006 16:13:01 -0600)
Subject: Re: fix list/edit command in hook-stop
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <43FDFCDE.9090603@cae.wisc.edu> <20060223210220.GC2353@nevyn.them.org> <43FE336D.1010502@cae.wisc.edu>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-02/txt/msg00454.txt.bz2

> Date: Thu, 23 Feb 2006 16:13:01 -0600
> From: Jason Kraftcheck <kraftche@cae.wisc.edu>
> CC: gdb-patches@sources.redhat.com
> 
> --- gdb-6.4/gdb/infrun.c	2005-11-14 09:35:16.000000000 -0600
> +++ mod/gdb/infrun.c	2006-02-23 15:28:44.485723627 -0600
> @@ -3041,8 +3041,12 @@ Further execution is probably impossible
>    /* Look up the hook_stop and run it (CLI internally handles problem
>       of stop_command's pre-hook not existing).  */
>    if (stop_command)
> -    catch_errors (hook_stop_stub, stop_command,
> -		  "Error while running hook_stop:\n", RETURN_MASK_ALL);
> +    {
> +      if (target_has_stack)
> +        set_current_sal_from_frame (get_current_frame (), 1);
> +      catch_errors (hook_stop_stub, stop_command,
> +		    "Error while running hook_stop:\n", RETURN_MASK_ALL);
> +    }
> 

I'd suggest a comment here explaining why set_current_sal_from_frame
is called.