Re: RFC: Fix various problems with "printf" and warnings

Daniel Jacobowitz
2006-02-02T02:26:58Z

On Sat, Jan 21, 2006 at 07:31:17PM -0500, Daniel Jacobowitz wrote:
> 2006-01-21 Daniel Jacobowitz <dan@codesourcery.com>
>
> * printcmd.c (printf_command): Make format string checking
> stricter. Add separate cases for long_arg, ptr_arg, and
> long_double_arg.
> * utils.c (xstrvprintf): Improve the error message issued
> for a bad format string.
> * Makefile.in (GDB_WARN_CFLAGS_NO_FORMAT, INTERNAL_CFLAGS_BASE):
> New variables.
> (gnu-v3-abi.o, monitor.o, procfs.o, linux-thread-db.o): Remove
> $(NO_WERROR_CFLAGS).
> (printcmd.o): Likewise. Use $(GDB_WARN_CFLAGS_NO_FORMAT) and
> enable -Werror.

Thanks to everyone who commented; I've now checked this in. A lot of
other targets aren't, but x86_64-linux native is now warning-free.