From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-42355-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27876 invoked by alias); 22 Jan 2006 04:28:04 -0000
Received: (qmail 27867 invoked by uid 22791); 22 Jan 2006 04:28:04 -0000
X-Spam-Check-By: sourceware.org
Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 22 Jan 2006 04:28:01 +0000
Received: from HOME-C4E4A596F7 (IGLD-80-230-52-29.inter.net.il [80.230.52.29]) 	by romy.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id DKH51051 (AUTH halo1); 	Sun, 22 Jan 2006 06:27:57 +0200 (IST)
Date: Sun, 22 Jan 2006 04:28:00 -0000
Message-Id: <uhd7wq42y.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org
In-reply-to: <20060122003117.GC8088@nevyn.them.org> (message from Daniel 	Jacobowitz on Sat, 21 Jan 2006 19:31:17 -0500)
Subject: Re: RFC: Fix various problems with "printf" and warnings
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <20060122003117.GC8088@nevyn.them.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-01/txt/msg00288.txt.bz2

> Date: Sat, 21 Jan 2006 19:31:17 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> +	      else if (*f == ' ')
> +		seen_space = 1;
> +	      else if (*f == ' ')
> +		seen_plus = 1;

A typo in the second "else if" clause.

> +	  case long_double_arg:
> +#ifdef HAVE_LONG_DOUBLE
> +	    {
> +	      long double val = value_as_double (val_args[i]);
> +	      printf_filtered (current_substring, val);

Won't `value_as_double' lose accuracy here, possibly catastrophically
(i.e., a non-zero number coming out as zero, etc.)?