From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20499 invoked by alias); 1 Apr 2006 12:34:45 -0000 Received: (qmail 20490 invoked by uid 22791); 1 Apr 2006 12:34:44 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 01 Apr 2006 12:34:44 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-13-61.inter.net.il [80.230.13.61]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id DWI29682 (AUTH halo1); Sat, 1 Apr 2006 15:34:38 +0300 (IDT) Date: Sat, 01 Apr 2006 12:34:00 -0000 Message-Id: From: Eli Zaretskii To: Michael Snyder CC: gdb-patches@sources.redhat.com In-reply-to: <442DAA95.6050708@redhat.com> (message from Michael Snyder on Fri, 31 Mar 2006 14:17:57 -0800) Subject: Re: [RFA] Reverse debugging, part 2/3: core interface Reply-to: Eli Zaretskii References: <442DAA95.6050708@redhat.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00001.txt.bz2 > *************** finish_command (char *arg, int from_tty) > *** 1311,1320 **** > source. */ > if (from_tty) > { > ! printf_filtered (_("Run till exit from ")); > print_stack_frame (get_selected_frame (NULL), 1, LOCATION); > } > > /* If running asynchronously and the target support asynchronous > execution, set things up for the rest of the finish command to be > completed later on, when gdb has detected that the target has > --- 1303,1333 ---- > source. */ > if (from_tty) > { > ! if (target_get_execution_direction () == EXEC_REVERSE) > ! printf_filtered ("Run back to call of "); > ! else > ! printf_filtered ("Run till exit from "); > ! > print_stack_frame (get_selected_frame (NULL), 1, LOCATION); > } The original code was i18n-ready, but your code is not. Please use _() to wrap messages we display to the user. In addition, I think "Run back to call of FOO" is not very clear. I wanted to suggest "Run to entry to FOO", but then I realized it would be a lie: we do back up past the entry, to the instruction that actually calls the function we are in, right? Perhaps "Run back to before the call to FOO" is better, even though it is wordier? > ! if (debug_infrun) > ! fprintf_unfiltered (gdb_stdlog, > ! "infrun: stepped to a different function\n"); _() is missing around the message string (yes, I know it was missing in the original code as well, but...). > + case NO_HISTORY: > + /* Reverse execution: target ran out of history info. */ > + ui_out_text (uiout, "\nNo more reverse-execution history.\n"); _(), please.