From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3934 invoked by alias); 8 Jul 2006 12:19:41 -0000 Received: (qmail 3925 invoked by uid 22791); 8 Jul 2006 12:19:40 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 08 Jul 2006 12:19:39 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-70-118.inter.net.il [80.230.70.118]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id EBC51718 (AUTH halo1); Sat, 8 Jul 2006 15:19:34 +0300 (IDT) Date: Sat, 08 Jul 2006 12:19:00 -0000 Message-Id: From: Eli Zaretskii To: Joel Brobecker CC: gdb-patches@sources.redhat.com In-reply-to: <20060707191203.GD971@adacore.com> (message from Joel Brobecker on Fri, 7 Jul 2006 12:12:03 -0700) Subject: Re: [RFA] New substitute-path commands Reply-to: Eli Zaretskii References: <20060705215606.GF3580@adacore.com> <20060705230129.GA1145@nevyn.them.org> <20060706044733.GC673@adacore.com> <1152198199.6282.63.camel@dufur.beaverton.ibm.com> <20060706162952.GB24631@nevyn.them.org> <20060707052219.GA971@adacore.com> <20060707191203.GD971@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00067.txt.bz2 > Date: Fri, 7 Jul 2006 12:12:03 -0700 > From: Joel Brobecker > Cc: gdb-patches@sources.redhat.com > > Thanks for your review (and also the effort you made in providing a > description of what a substitution rule is, much appreciated). I have > updated the source as per your comments, as well as reworked the > documentation to include your ideas. Thanks, I'm almost happy now. > I also took the time to include a > small explaination of how this new functionality differs slightly from > the "dir" command. It's not necessary since the explaination can be > deduced from the rest of the documentation, but might make it easier to > figure this out. I think it's a good addition, thanks. > +directory between compilation and debugging. @value{GDBN} does a simple > +string replacement of the first occurrence of @var{from} with @var{to} > +in the directory part of the source file name, and uses the result > +instead of the original file name to look up the sources. I suggested to have this text after the command description. In that context, @var{from} and @var{to} refer to the command's arguments. But you moved the description higher in the text, which made those reference dangling. So this needs to be reworded in some way. > +However, @code{set substitute-path} is also more than just a shortcut This However is redundant here, I think.