From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10124 invoked by alias); 8 Aug 2006 19:16:40 -0000 Received: (qmail 10116 invoked by uid 22791); 8 Aug 2006 19:16:38 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 08 Aug 2006 19:16:37 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-37-8.inter.net.il [80.230.37.8]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id FLV92394 (AUTH halo1); Tue, 8 Aug 2006 22:16:34 +0300 (IDT) Date: Tue, 08 Aug 2006 19:16:00 -0000 Message-Id: From: Eli Zaretskii To: gdb-patches@sourceware.org In-reply-to: <20060808180706.GC24779@nevyn.them.org> (message from Daniel Jacobowitz on Tue, 8 Aug 2006 14:07:06 -0400) Subject: Re: [RFC, take 2] Optional expat Reply-to: Eli Zaretskii References: <20060808180706.GC24779@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-08/txt/msg00053.txt.bz2 > Date: Tue, 8 Aug 2006 14:07:06 -0400 > From: Daniel Jacobowitz > > +@node Requirements > +@section Requirements for building @value{GDBN} I think this section would benefit from at least one @cindex entry. > +use the @samp{--with-libexpat-prefix} option to specify its location. I think @option is better than @samp here. > +@cindex configuring @value{GDBN} > +@cindex configuring @value{GDBN}, and source tree subdirectories Please remove the second @cindex entry. (Yes, I know you just moved it from the current place.) It's a bad idea to have several index entries that begin with the same (long) string and point to the same page. Other than that, the doco patch is okay with me.