Re: [PATCH] MI: new timing command

Daniel Jacobowitz
2007-01-03T22:59:39Z

On Thu, Jan 04, 2007 at 10:49:54AM +1300, Nick Roberts wrote:
> > I don't even understand why we're having this conversation. Please
> > follow the coding standard unless you have a good justification not to;
> > that's why we call it the standard. Thanks.
>
> Sure, I didn't say that I wouldn't do it. I'm just waiting for Eli to tell
> me if it works with get_run_time. Meanwhile here's a revised version of
> mi-main.c. I've even made line breaks before, instead of after, operators!

Please... (from gdb/CONTRIBUTE):

o Please read your patch before submitting it.

A patch containing several unrelated changes or
arbitrary reformats will be returned with a request
to re-formatting / split it.

If you're volunteering to fix up formatting in the MI files, go right
ahead; patches which only fix formatting problems are obvious, as long
as you've proofread them. But patches which mix code changes and
formatting changes are pretty much impossible to read. The one you
just posted, for instance, was 40K and had about twenty lines of actual
new code in it.

--
Daniel Jacobowitz
CodeSourcery