From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18272 invoked by alias); 17 Dec 2007 20:06:55 -0000 Received: (qmail 18262 invoked by uid 22791); 17 Dec 2007 20:06:54 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (213.8.233.22) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Dec 2007 20:06:43 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-198-53.inter.net.il [80.230.198.53]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id IOS59128 (AUTH halo1); Mon, 17 Dec 2007 22:04:03 +0200 (IST) Date: Mon, 17 Dec 2007 20:35:00 -0000 Message-Id: From: Eli Zaretskii To: Joel Brobecker CC: uweigand@de.ibm.com, gdb-patches@sourceware.org In-reply-to: <20071217064213.GC9022@adacore.com> (message from Joel Brobecker on Mon, 17 Dec 2007 10:42:13 +0400) Subject: Re: [RFC/RFA] Introduce new struct parse_context Reply-to: Eli Zaretskii References: <20071217064213.GC9022@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00283.txt.bz2 > Date: Mon, 17 Dec 2007 10:42:13 +0400 > From: Joel Brobecker > > I would like to introduce a new structure called "struct parse_context" > which, for now, would contain the language and radix to use when doing > some parsing. This is something that we already discussed in a more > general way. Thanks! > This patch introduces: > > - struct parse_context > > - A function called "build_parse_context" that builds a parse_context > structure from a language and radix. Eventually, when the struct > grows, we will add more parameters to that function. > > - A macro: current_parse_context which returns a parse context using > the current_language and the input_radix. This is the context that > we should be using when parsing from a function that is a "command" > (that is a function that implements a command) > > - A macro: wrong_parse_context, which is an alias to current_parse_context. > This macro is useful to help breaking this task into incremental changes > and is temporary, as the FIXME explains. I am using this macro when > I am in a context where I don't have the parse_context to be used (yet), > to make sure that I don't forget to fix it later. Will be removed > when the task is complete. How about if we try to document in gdbint.texinfo each new infrastructure we introduce, from now on? Would other maintainers support such a requirement from contributors? I can offer text-to-Texinfo conversion services (and, of course, general help in writing documentation), if someone does not feel up to speed with Texinfo. WDYT?