From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-56493-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3054 invoked by alias); 6 Jun 2008 10:13:03 -0000
Received: (qmail 3044 invoked by uid 22791); 6 Jun 2008 10:13:03 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 06 Jun 2008 10:12:43 +0000
Received: from HOME-C4E4A596F7 ([83.130.2.23]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K21003TPCWAXEL0@i-mtaout7.012.net.il> for gdb-patches@sources.redhat.com; Fri, 06 Jun 2008 12:55:35 +0300 (IDT)
Date: Fri, 06 Jun 2008 10:13:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Patch to limit field name completion candidates
In-reply-to: <m34p87d2u8.fsf@fleche.redhat.com>
X-012-Sender: halo1@inter.net.il
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sources.redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uhcc6c1ot.fsf@gnu.org>
References: <m38wyf6py1.fsf@fleche.redhat.com> <20080605170952.GJ29085@caradoc.them.org> <m3k5h3d6xt.fsf@fleche.redhat.com> <20080605194553.GG25085@caradoc.them.org> <m34p87d2u8.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-06/txt/msg00107.txt.bz2

> From: Tom Tromey <tromey@redhat.com>
> Date: Thu, 05 Jun 2008 14:49:35 -0600
> 
> + @cindex completion of field names
> + @cindex field name completion
> + When completing in an expression which looks up a field in a
> + structure, @value{GDBN} also tries to limit completions to the field
> + names available in the type of the left-hand-side:
> + 
> + @smallexample
> + (@value{GDBP}) p gdb_stdout.@key{M-?}
> + magic      to_delete  to_fputs   to_put     to_rewind  
> + to_data    to_flush   to_isatty  to_read    to_write   
> + @end smallexample
> + 

  Otherwise, 

This is good.  I have three comments:

 . in the @cindex entries, I think it's better to use "structure
   fields" instead of just "fields", at least in one of them;

 . please use @kbd{M-?}, not @key (there's no key labeled literally
   with M-?);

 . not every GDB user knows by heart the definition of the ui_file
   structure, so I'd add the following passage right after your text:

 @noindent
 This is because the @code{gdb_stdout} is a variable of the type
 @code{struct ui_file} that is defined in @value{GDBN} sources as
 follows:

 @smallexample
 struct ui_file
 @{
    int *magic;
    ui_file_flush_ftype *to_flush;
    ui_file_write_ftype *to_write;
    ui_file_fputs_ftype *to_fputs;
    ui_file_read_ftype *to_read;
    ui_file_delete_ftype *to_delete;
    ui_file_isatty_ftype *to_isatty;
    ui_file_rewind_ftype *to_rewind;
    ui_file_put_ftype *to_put;
    void *to_data;
 @}
 @end smallexample