From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4376 invoked by alias); 21 Nov 2005 22:05:57 -0000 Received: (qmail 4369 invoked by uid 22791); 21 Nov 2005 22:05:56 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 21 Nov 2005 22:05:55 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-228-243-191.inter.net.il [84.228.243.191]) by nitzan.inter.net.il (MOS 3.6.5-GR) with ESMTP id BZM70903 (AUTH halo1); Tue, 22 Nov 2005 00:05:43 +0200 (IST) Date: Tue, 22 Nov 2005 05:38:00 -0000 Message-Id: From: Eli Zaretskii To: Andrew STUBBS CC: gdb-patches@sources.redhat.com In-reply-to: <4382072A.1010402@st.com> (message from Andrew STUBBS on Mon, 21 Nov 2005 17:43:06 +0000) Subject: Re: [PATCH] Fix 'Undefined command' error message Reply-to: Eli Zaretskii References: <4379EC0A.3060601@st.com> <20051116201300.GA23472@nevyn.them.org> <4382072A.1010402@st.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00399.txt.bz2 > Date: Mon, 21 Nov 2005 17:43:06 +0000 > From: Andrew STUBBS > Cc: gdb-patches@sources.redhat.com > > Eli Zaretskii wrote: > > I'd prefer to have the same characters allowed in all CLI commands. > > Any other way would be very confusing to users. > > > > Thanks for the other clarifications. I think we should at least add > > comments that explain the respective characters. > > I have moved all three instances of this code in to one function, added > comments, removed the pointless '*p' and allowed the TUI characters all > the time. > > The XDB characters clash with existing GDB commands so I have left those > disabled unless in XDB mode. Specifically commands such as 'x/i' fail > because the command there is actually only 'x'. Obviously this does not > affect commands such as 'x /i'. Thanks, I'm happy with this patch.