From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2554 invoked by alias); 10 Oct 2006 21:24:46 -0000 Received: (qmail 2542 invoked by uid 22791); 10 Oct 2006 21:24:45 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Oct 2006 21:24:43 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-228-242-30.inter.net.il [84.228.242.30]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id FZA76859 (AUTH halo1); Tue, 10 Oct 2006 23:24:36 +0200 (IST) Date: Tue, 10 Oct 2006 21:24:00 -0000 Message-Id: From: Eli Zaretskii To: Denis PILAT CC: gdb-patches@sourceware.org In-reply-to: <452B9EB9.4040709@st.com> (message from Denis PILAT on Tue, 10 Oct 2006 15:23:05 +0200) Subject: Re: [TUI] correctly display windows source files Reply-to: Eli Zaretskii References: <452A6905.1040308@st.com> <452B9EB9.4040709@st.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00095.txt.bz2 > Date: Tue, 10 Oct 2006 15:23:05 +0200 > From: Denis PILAT > Cc: gdb-patches@sourceware.org > > About your remark, > I've tried to ungetc(EOF) and I did not get any problem, after > ungetc(EOF) the next call to fgetc is still EOF. That could be so, but I'd prefer that our code didn't do anything that could fail, even theoretically. We shouldn't call functions with arguments that invoke undefined or uncertain behavior. It should be a simple matter of adding a test for EOF.