From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58559-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29171 invoked by alias); 12 Sep 2008 16:10:07 -0000
Received: (qmail 29157 invoked by uid 22791); 12 Sep 2008 16:10:07 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout6.012.net.il (HELO mtaout6.012.net.il) (84.95.2.16)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 12 Sep 2008 16:09:25 +0000
Received: from HOME-C4E4A596F7 ([87.70.226.149]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K73006HXBL0IR50@i-mtaout6.012.net.il> for gdb-patches@sourceware.org; Fri, 12 Sep 2008 19:10:13 +0300 (IDT)
Date: Fri, 12 Sep 2008 16:10:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA 03/08] multi-process support: remote multi-process extensions
In-reply-to: <200809121638.59063.pedro@codesourcery.com>
X-012-Sender: halo1@inter.net.il
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <ufxo5pcqx.fsf@gnu.org>
References: <200809121638.59063.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-09/txt/msg00270.txt.bz2

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Fri, 12 Sep 2008 16:38:58 +0100
> 
> -      if (extended)
> -	puts_filtered ("Detached from remote process.\n");
> +      if (rs->multi_process_aware)
> +	printf_filtered ("Detached from %s.\n",
> +			 target_pid_to_str (pid_to_ptid (pid)));
>        else
> -	puts_filtered ("Ending remote debugging.\n");
> +	{
> +	  /* Unregister the file descriptor from the event loop.  */
> +	  if (target_is_async_p ())
> +	    serial_async (remote_desc, NULL, 0);
> +
> +	  if (extended)
> +	    puts_filtered ("Detached from remote process.\n");
> +	  else
> +	    puts_filtered ("Ending remote debugging.\n");
> +	}

Please put all user-visible messages inside _().