From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19878 invoked by alias); 25 Mar 2004 06:43:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19870 invoked from network); 25 Mar 2004 06:43:00 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 25 Mar 2004 06:43:00 -0000 Received: from [207.232.27.5] (helo=WST0054) by monty-python.gnu.org with asmtp (Exim 4.30) id 1B6OWe-0006By-Sj; Thu, 25 Mar 2004 01:39:37 -0500 Date: Thu, 25 Mar 2004 06:43:00 -0000 Message-Id: From: Eli Zaretskii To: Bob Rossi CC: rms@gnu.org,gdbheads@gnu.org,gdb-patches@sources.redhat.com In-reply-to: <20040325041331.GD19966@white> (message from Bob Rossi on Wed, 24 Mar 2004 23:13:31 -0500) Subject: Re: [Gdbheads] Re: Feb's patch resolution rate Reply-to: Eli Zaretskii References: <20040225040059.GB19094@white> <16456.65451.461753.66554@localhost.redhat.com> <20040306155700.GA9439@white> <20040311132508.GA2504@white> <20040323130900.GA17339@white> <4060A523.6010801@gnu.org> <4060ACC8.10209@gnu.org> <20040325041331.GD19966@white> X-SW-Source: 2004-03/txt/msg00597.txt.bz2 > Date: Wed, 24 Mar 2004 23:13:31 -0500 > From: Bob Rossi > > Is quick linear with the size of the patch? No, not IMO. A large patch takes longer to review, but it's not true that a 20-line patch takes twice as much as a 10-line patch. To me, most of the reviewing time is spent looking at the current sources and thinking about potential problems with the patch applied, or testing the patched version. These activities don't take time that is proportional to the patch size. IMHO, a patch that is too long to be reviewed in reasonable time is too long, period. The person who submitted such a patch should be asked to break it down into several smaller patches. > To me one month is not quick. Is it to anyone else? Everyone seems to > ignore this question :) I think one month is too long. (There, I didn't ignore it ;-) > The real question is, what incentive does a maintainer have to review a > patch quickly? None, except his/her own sense of a job well done (or not so well done). > Also, if the testsuite passes, and the initial patch looks good, why > would it take so long to accept the patch? The problem is precisely that: deciding whether the patch ``looks good''. It's not a trivial decision to make. One needs to think about possible implications of the patch, both in its immediate area and elsewhere in GDB. There are no automated procedures for that. That's why we need human maintainers, and that's why maintainers don't always agree on whether a patch should go in as is. > Isn't the definition of "stable" for GDB, "The testsuite works the > same way after the patch as before"? You seem to assume that the test suite tests every possible aspect of GDB. That isn't true, unfortunately.