From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-43018-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29773 invoked by alias); 24 Feb 2006 08:13:38 -0000
Received: (qmail 29760 invoked by uid 22791); 24 Feb 2006 08:13:37 -0000
X-Spam-Check-By: sourceware.org
Received: from gandalf.inter.net.il (HELO gandalf.inter.net.il) (192.114.186.17)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Feb 2006 08:13:37 +0000
Received: from nitzan.inter.net.il (nitzan.inter.net.il [192.114.186.20]) 	by gandalf.inter.net.il (MOS 3.7.1-GA) 	with ESMTP id HYV07654; 	Fri, 24 Feb 2006 10:13:00 +0200 (IST)
Received: from HOME-C4E4A596F7 (IGLD-83-130-198-86.inter.net.il [83.130.198.86]) 	by nitzan.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id CTU48089 (AUTH halo1); 	Fri, 24 Feb 2006 10:12:57 +0200 (IST)
Date: Fri, 24 Feb 2006 08:34:00 -0000
Message-Id: <uek1t9nu6.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Wu Zhou <woodzltc@cn.ibm.com>
CC: gdb-patches@sources.redhat.com
In-reply-to: <Pine.LNX.4.64.0602240250300.7628@localhost.localdomain> (message 	from Wu Zhou on Fri, 24 Feb 2006 02:54:16 -0500 (EST))
Subject: Re: [RFC]: Document patch for F90 derived type support
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <Pine.LNX.4.64.0602240250300.7628@localhost.localdomain>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-02/txt/msg00456.txt.bz2

> Date: Fri, 24 Feb 2006 02:54:16 -0500 (EST)
> From: Wu Zhou <woodzltc@cn.ibm.com>
> 
> Here is the modified document patch for F90 derived type support.  Please 
> review and comment.

Reviewed; comments below.

> + Fortran 90 and later support derived type (a.k.a structure).  For a
                                               ^^^^^
This should be "a.k.a.@:".  You forgot the last period, and @: tells
TeX that this period does not end a sentence, so that TeX typeset it
correctly.

> + type = Type bar
> +     int4 :: c
> +     real*4 :: d
> + End Type bar

Btw, isn't it more consistent to print "integer*4" instead of "int4"?
Either that, or just "integer", I think.  Or is "int4" a valid type
name in f90?  (The last Fortran I used was f77, so please forgive my
ignorance.)

> + For example, for variable q of type foo defined above:

"q" and "foo" should be in @code (they are program symbols).

> + Please be noted that in the above example, the result of @code{print q}
    ^^^^^^^^^^^^^^^
"Please note".

Other than that, fine with me.  Thanks.