From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29005 invoked by alias); 31 Oct 2006 04:19:42 -0000 Received: (qmail 28997 invoked by uid 22791); 31 Oct 2006 04:19:41 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 31 Oct 2006 04:19:38 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-5-161.inter.net.il [80.230.5.161]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id GCY45012 (AUTH halo1); Tue, 31 Oct 2006 06:19:31 +0200 (IST) Date: Tue, 31 Oct 2006 04:19:00 -0000 Message-Id: From: Eli Zaretskii To: David Taylor CC: gdb-patches@sourceware.org In-reply-to: <200610302225.k9UMPLZ9001050@mailhub.lss.emc.com> (message from David Taylor on Mon, 30 Oct 2006 17:25:21 -0500) Subject: Re: stabs.texinfo update for macro define/undefine Reply-to: Eli Zaretskii References: <200610251931.k9PJVRDO011265@mailhub.lss.emc.com> <200610302225.k9UMPLZ9001050@mailhub.lss.emc.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00308.txt.bz2 > cc: Eli Zaretskii > Date: Mon, 30 Oct 2006 17:25:21 -0500 > From: David Taylor > > Patch to add information about recording macro define and undefine > information in stabs. Thanks. > +@node Macro define and undefine > +@chapter Representation of #define and #undef > + > +Macro define and undefine. This last sentence is redundant (and actually isn't even a sentence). > +information, supported on some systems. (e.g., with -g3 -gstabs when Please put command-line options in @option. > +using gcc). Please use GCC instead of gcc. > +A @code{#define @var{macro-name} @var{macro-body}} is represented with > +an @code{N_MAC_DEFINE} stab with a string field of > +@code{@var{macro-name} @var{macro-body}}. > +@findex N_MAC_DEFINE > + > +An @code{#undef @var{macro-name}} is represented with an > +@code{N_MAC_UNDEF} stabs with a string field of simply > +@code{@var{macro-name}}. > +@findex N_MAC_UNDEF > + > +For both @code{N_MAC_DEFINE} and @code{N_MAC_UNDEF}, the desc field is > +the line number within the file where the corresponding @code{#define} > +or @code{#undef} occurred. > +@findex N_MAC_DEFINE > +@findex N_MAC_UNDEF It is not useful to have two identical index entries that point to the same page. In this case, I don't see the need for the second pair of @findex entries here. > +@end example > + > +produces the following stabs (as well as many others): You need a @noindent before this line, since you don't want it to be indented as if it were a new paragraph. > +@example > + .stabs "NONE 42",54,0,1,0 # 54 is N_MAC_DEFINE > + .stabs "TWO(a,b) (a + (a) + 2 * b)",54,0,2,0 # 54 is N_MAC_DEFINE > + .stabs "ONE(c) (c + 19)",54,0,3,0 # 54 is N_MAC_DEFINE > + .stabs "ONE",58,0,10,0 # 58 is N_MAC_UNDEF > + .stabs "ONE(c) (c + 23)",54,0,11,0 # 54 is N_MAC_DEFINE > +@end example These lines are too long: they will overflow the page margin in the printed version of the manual. I suggest to remove the comments and instead explain the meaning of the constants in a separate text. (Didn't I tell you this when you first posted the suggested text?) Please also post the ChangeLog entry for the patch. With these changes, this can go in. Thanks.