From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-52929-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11287 invoked by alias); 29 Dec 2007 11:47:58 -0000
Received: (qmail 11278 invoked by uid 22791); 29 Dec 2007 11:47:57 -0000
X-Spam-Check-By: sourceware.org
Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 29 Dec 2007 11:47:51 +0000
Received: from HOME-C4E4A596F7 (IGLD-84-229-120-75.inter.net.il [84.229.120.75]) 	by romy.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id JTD87587 (AUTH halo1); 	Sat, 29 Dec 2007 13:47:30 +0200 (IST)
Date: Sat, 29 Dec 2007 12:53:00 -0000
Message-Id: <uejd5yb6c.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
CC: gdb-patches@sourceware.org
In-reply-to: <1198816387.12907.62.camel@localhost.localdomain> (message from 	Thiago Jung Bauermann on Fri, 28 Dec 2007 02:33:07 -0200)
Subject: Re: [patch 2/2] Wrap-up expression support for DFP.
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <20071220054926.148275471@br.ibm.com> 	 <20071220055107.194393592@br.ibm.com>  <uzlw4hw5f.fsf@gnu.org> <1198816387.12907.62.camel@localhost.localdomain>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-12/txt/msg00451.txt.bz2

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Fri, 28 Dec 2007 02:33:07 -0200
> 
> I couldn't find an appropriate place to put these in the manual, so I
> went ahead and created a new sub-section, under "Examining Data". What
> do you think?

I think a better place is in the "C and C++" section.  These are C/C++
data types, aren't they?

> +There are two encodings in use, depending on the architecture: BID (Binary
> +Integer Decimal) for x86 and x86-64, and DPD (Densely Packed Decimal) for
> +PowerPC. GDB will use the appropriate encoding for the configured target.

PLease use "@value{GDBN}" instead of a literal "GDB".

> +Because of a limitation in libdecnumber, the library used by @value{GDBN}

"libdecnumber" is a file name, so it should have the @file markup.

> +point computations, error checking in decimal float operations ignore underflow,

"ignores".

Other than these comments, the patch is okay to go in (as a subsection
of the "C and C++" section.

Thanks.