From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-56337-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11203 invoked by alias); 28 May 2008 19:15:31 -0000
Received: (qmail 11192 invoked by uid 22791); 28 May 2008 19:15:31 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 May 2008 19:15:11 +0000
Received: from HOME-C4E4A596F7 ([83.130.219.40]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K1L00HYHFH031E0@i-mtaout1.012.net.il> for gdb-patches@sources.redhat.com; Wed, 28 May 2008 22:29:24 +0300 (IDT)
Date: Wed, 28 May 2008 23:10:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch/MI] Implementation for break-catch command
In-reply-to: <483D9B0C.20606@qnx.com>
X-012-Sender: halo1@inter.net.il
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: gdb-patches@sources.redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uej7m8cm6.fsf@gnu.org>
Content-transfer-encoding: 7BIT
References: <g1jt6h$ebt$1@ger.gmane.org> <g1k116$qgg$1@ger.gmane.org> <483D9B0C.20606@qnx.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-05/txt/msg00738.txt.bz2

> From:  Aleksandar Ristovski <aristovski@qnx.com>
> Date:  Wed, 28 May 2008 13:49:00 -0400
> Cc:  Eli Zaretskii <eliz@gnu.org>
> 
> Cc-ing Eli for doc. changes review.

Fine with me, except for the following gotchas:

> +@subsubheading Synopsis
> +
> +@smallexample
> + -break-catch [ -t ] [ @var{event} ]
> +@end smallexample
> +
> +@noindent
> +Where @var{event} can be one of:

This "where" should not be capitalized, since it does not begin a new
sentence.

> +@smallexample
> +^done,bkpt=@{number="@var{number}",type="@var{type}",disp="del"|"keep",
> +enabled="y"|"n",addr="@var{hex}",what="exception catch"|"exception throw",
> +times="@var{times}",original-location="@var{funcname}"@}
> +@end smallexample

The lines here are too long: anything longer than 66 characters runs a
risk of overflowing the page margin in the printed manual.  So please
break them into shorter lines.

> +where @var{number} is the @value{GDBN} number for this breakpoint,

"breakpoint" or "catchpoint"?

> +the breakpoint has been hit (always 0 for -break-catch but may be 
> +greater for -break-info or -break-list which use the same output).

Please give commands you mention here the @code markup.

Thanks.