Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@elta.co.il>
To: Baurjan Ismagulov <ibr@ata.cs.hun.edu.tr>
Cc: gdb-patches@sources.redhat.com
Subject: Re: handling of absolute source file paths
Date: Wed, 21 Apr 2004 05:51:00 -0000	[thread overview]
Message-ID: <ud661962c.fsf@elta.co.il> (raw)
In-Reply-To: <20040420154855.GD9020@ata.cs.hacettepe.edu.tr> (message from Baurjan Ismagulov on Tue, 20 Apr 2004 18:48:57 +0300)

> Date: Tue, 20 Apr 2004 18:48:57 +0300
> From: Baurjan Ismagulov <ibr@ata.cs.hun.edu.tr>
> 
> considering http://sources.redhat.com/gdb/current/onlinedocs/gdb_8.html
> , I expect the following behaviour:

Actually, the manual doesn't describe what happens in the specific
case you are talking about: it says

  Each time GDB wants a source file, it tries all the directories in
  the list, in the order they are present in the list, until it finds
  a file with the desired name

Note that it doesn't specify what happens if the file's name starts
with a slash or otherwise has leading directories.  It would be good
to augment the manual with a more explicit description of cases such
as yours.  Would you like to do that?

> However, due to a change discussed in
> http://sources.redhat.com/ml/gdb/2004-01/msg00243.html , gdb isn't able
> to find the source even after the "directory" command; I consider this
> to be a bug. We've implemented the change proposed in
> http://sources.redhat.com/ml/gdb/2004-03/msg00026.html . The patched
> version behaves the same for binaries, but finds the sources if the
> "directory" command was issued.

First, please in the future send patches as plain text, not as
compressed binary attachments; that might help your patches to be
reviewed sooner.

> I suggest that it is included for stable and unstable branches. What do
> you think?

The patch looks good to me, and I think I can approve it (Andrew?).
So, unless someone else objected, it can go in.  However,

> I consider this patch to be not legally significant. Please inform me if
> you need a copyright assignment.

I don't know if you need an assignment for this patch, so I'll let
others to give you a definitive answer.

Thanks!


  reply	other threads:[~2004-04-21  5:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-20 15:49 Baurjan Ismagulov
2004-04-21  5:51 ` Eli Zaretskii [this message]
2004-04-21 11:10   ` Baurjan Ismagulov
2004-05-01 17:01   ` Baurjan Ismagulov
2004-05-02 13:15     ` Eli Zaretskii
2004-05-01 17:12   ` Baurjan Ismagulov
2004-05-01 18:11     ` Eli Zaretskii
2004-05-08 21:20       ` Baurjan Ismagulov
2004-05-09 14:33         ` Eli Zaretskii
2004-05-09 13:53           ` Baurjan Ismagulov
2004-05-11 16:08         ` Eli Zaretskii
2004-07-17 18:20           ` Baurjan Ismagulov
2004-07-23 19:55             ` ping: " Baurjan Ismagulov
2004-07-24  7:21               ` Eli Zaretskii
2004-07-26 14:57                 ` Andrew Cagney
2004-07-26 15:20                   ` Baurjan Ismagulov
2004-07-26 17:48                     ` Eli Zaretskii
2004-07-26 18:15                     ` Andrew Cagney
2004-07-26 17:47                   ` Eli Zaretskii
2004-07-30 19:19             ` Eli Zaretskii
2004-07-31  7:57               ` Baurjan Ismagulov
2004-07-31  8:25                 ` Eli Zaretskii
2004-08-01 19:31                   ` Andrew Cagney
2004-08-03 16:59                     ` Baurjan Ismagulov
2004-08-03 19:12                       ` Eli Zaretskii
2004-08-04  7:02                         ` Baurjan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ud661962c.fsf@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ibr@ata.cs.hun.edu.tr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox