From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24136 invoked by alias); 9 Feb 2006 20:40:53 -0000 Received: (qmail 24124 invoked by uid 22791); 9 Feb 2006 20:40:52 -0000 X-Spam-Check-By: sourceware.org Received: from gandalf.inter.net.il (HELO gandalf.inter.net.il) (192.114.186.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 09 Feb 2006 20:40:51 +0000 Received: from nitzan.inter.net.il (nitzan.inter.net.il [192.114.186.20]) by gandalf.inter.net.il (MOS 3.7.1-GA) with ESMTP id HVE18334; Thu, 9 Feb 2006 22:38:52 +0200 (IST) Received: from HOME-C4E4A596F7 (IGLD-80-230-71-5.inter.net.il [80.230.71.5]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id CRC09494 (AUTH halo1); Thu, 9 Feb 2006 22:38:51 +0200 (IST) Date: Thu, 09 Feb 2006 20:40:00 -0000 Message-Id: From: Eli Zaretskii To: gdb-patches@sourceware.org In-reply-to: <20060209145753.GA25270@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 9 Feb 2006 09:57:53 -0500) Subject: Re: RFA: Support Windows extended error numbers in safe_strerror Reply-to: Eli Zaretskii References: <20060203215455.GA3501@nevyn.them.org> <20060206173550.GB22947@nevyn.them.org> <200602062254.k16MsagK009925@elgar.sibelius.xs4all.nl> <20060206225829.GA31895@nevyn.them.org> <20060208000855.GA5040@nevyn.them.org> <200602082107.k18L7xRh013417@elgar.sibelius.xs4all.nl> <200602082310.k18NAQNe027038@elgar.sibelius.xs4all.nl> <15661.192.87.1.22.1139496247.squirrel@webmail.xs4all.nl> <20060209145753.GA25270@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00220.txt.bz2 > Date: Thu, 9 Feb 2006 09:57:53 -0500 > From: Daniel Jacobowitz > Cc: Eli Zaretskii , gdb-patches@sourceware.org > > Of course there's a flip side. If I do it Eli's way, the default > version has to compile and link. Which happens to be the case for > the two examples we have today, but also a pretty limiting assumption. If the default version doesn't compile on the platform that needs the hook, the solution is simple: define enough macros and stub functions to effectively make it the default version a nop on that platform. But in practice, the need for this rarely if ever arises. Macros and global symbols that are highly unportable tend to be used only if defined, as in: #if defined (TIOCGWINSZ) if (ioctl (tty, TIOCGWINSZ, &window_size) == 0) { _rl_screenwidth = (int) window_size.ws_col; _rl_screenheight = (int) window_size.ws_row; } #endif /* TIOCGWINSZ */