Re: [RFA] -list-target-groups --available

Vladimir Prus
2008-11-22T16:39:29Z

On Thursday 20 November 2008 17:42:26 Daniel Jacobowitz wrote:
> On Fri, Nov 14, 2008 at 08:03:33PM +0300, Vladimir Prus wrote:
> >
> > This patch implements MI '-list-target-groups --available' -- for
> > native linux and remote targets. In both cases, the command actually
> > returns the list of processes. The bulk of the patch was written by
> > Pedro, I've just added MI bits to it.
>
> All the code looks OK to me. However, I would not like to add this
> patch without testcases or documentation. There should be a DTD
> somewhere, too.

This version has DTD. It also has documentation -- Eli, can you review it.
I did you found a good place where new "info os processes" should be documented,
any suggestions?

I've also added a minimal test for the new functionality -- it basically makes
sure we can get some process list, when using gdbserver on linux. Given that it's
very system-dependent, I don't think we can do better.

>
> > +void
> > +_initialize_osdata (void)
> > +{
> > + add_info ("os", info_osdata_command,
> > + _("Show OS data ARG."));
> > +
> > + /* An alias for "info osdata processes". */
> > + add_info ("processes", info_processes_command,
> > + _("List running processes on the target."));
> > +}
>
> "info os processes" or "info osdata"?

I wonder if the alias should be dropped -- "info processes" can
be easily confused with "info inferiors".

- Volodya