From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61851-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6662 invoked by alias); 24 Feb 2009 18:52:22 -0000
Received: (qmail 6548 invoked by uid 22791); 24 Feb 2009 18:52:19 -0000
X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Feb 2009 18:52:07 +0000
Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KFL006002QTYO00@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Tue, 24 Feb 2009 20:52:19 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.160.251]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KFL0091P336REE1@i_mtaout5.012.net.il>; Tue, 24 Feb 2009 20:52:19 +0200 (IST)
Date: Tue, 24 Feb 2009 19:46:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Add _() to query
In-reply-to: <daef60380902232310n32eb1f22m71265f0a38a952b1@mail.gmail.com>
To: teawater <teawater@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <ud4d7r7l7.fsf@gnu.org>
References: <daef60380902232310n32eb1f22m71265f0a38a952b1@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-02/txt/msg00470.txt.bz2

> Date: Tue, 24 Feb 2009 15:10:51 +0800
> From: teawater <teawater@gmail.com>
> 
> Hi Eli,
> 
> I remember you told me that you want to add _() to all query.
> I make a patch for it. Do you think it's OK?

Yes, with the exception of a single comment below.

(I don't have an opinion regarding the _() vs --keyword approach to
marking translatable strings.)

> -  if (from_tty && (!query ("%s", "")))
> +  if (from_tty && (!query (_("%s"), "")))

AFAIK, it is absolutely pointless to mark for translation strings that
have no text, just formatted output conversion spec.  That's because
the only translation of such strings is the string itself.