From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2376 invoked by alias); 18 Mar 2009 04:19:38 -0000 Received: (qmail 2367 invoked by uid 22791); 18 Mar 2009 04:19:37 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout6.012.net.il (HELO mtaout6.012.net.il) (84.95.2.16) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Mar 2009 04:19:29 +0000 Received: from conversion-daemon.i-mtaout6.012.net.il by i-mtaout6.012.net.il (HyperSendmail v2007.08) id <0KGO00700O0NVZ00@i-mtaout6.012.net.il> for gdb-patches@sourceware.org; Wed, 18 Mar 2009 06:20:15 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.127.23.114]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KGO00I30PDQZQC1@i-mtaout6.012.net.il>; Wed, 18 Mar 2009 06:20:15 +0200 (IST) Date: Wed, 18 Mar 2009 04:20:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] PR exp/9103 In-reply-to: To: Tom Tromey Cc: mark.kettenis@xs4all.nl, brobecker@adacore.com, bauerman@br.ibm.com, andreolb@gmail.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <20090311153711.GA5197@caradoc.them.org> <1236803010.11106.50.camel@localhost.localdomain> <20090313232515.GD30693@adacore.com> <200903132337.n2DNb26P011841@brahms.sibelius.xs4all.nl> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00361.txt.bz2 > Cc: mark.kettenis@xs4all.nl, brobecker@adacore.com, bauerman@br.ibm.com, > andreolb@gmail.com, gdb-patches@sourceware.org > From: Tom Tromey > Date: Tue, 17 Mar 2009 20:50:50 -0600 > > Thanks, after this I noticed that the manual has a section on install > requirements. What do you think of the appended patch? It's okay, but I have two comments: > +@item iconv > +@value{GDBN}'s features related to character sets require a > +functioning @code{iconv} implementation. I think it would be good here to add a cross-reference to where these features are described, to make more clear what is at stake. > +@value{GDBN}'s top-level @file{configure} and @file{Makefile} will > +arrange to build Libiconv if a directory named @file{libiconv} appears > +in the @file{src} directory. `src'? Ah, you are talking about the `src' tree that includes GDB, Binutils, libiberty, bfd, etc., right? I'm not sure this will be clear to anyone who does not habitually build these packages out of the same tree. How about adding that you are talking about the the `libiconv' directory being a sibling directory to `gdb' under the same parent directory? (Does it have to be called `src', btw?)