From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-41464-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22313 invoked by alias); 16 Nov 2005 19:50:23 -0000
Received: (qmail 22246 invoked by uid 22791); 16 Nov 2005 19:50:19 -0000
Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 16 Nov 2005 19:50:19 +0000
Received: from HOME-C4E4A596F7 (IGLD-80-230-33-244.inter.net.il [80.230.33.244])
	by nitzan.inter.net.il (MOS 3.6.5-GR)
	with ESMTP id BYR63649 (AUTH halo1);
	Wed, 16 Nov 2005 21:50:10 +0200 (IST)
Date: Wed, 16 Nov 2005 20:11:00 -0000
Message-Id: <ubr0k74p7.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew STUBBS <andrew.stubbs@st.com>
CC: gdb-patches@sources.redhat.com
In-reply-to: <437B6228.8010103@st.com> (message from Andrew STUBBS on Wed, 16
	Nov 2005 16:45:28 +0000)
Subject: Re: [PATCH] command trace / source verbose mode
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <437B6228.8010103@st.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2005-11/txt/msg00247.txt.bz2

> Date: Wed, 16 Nov 2005 16:45:28 +0000
> From: Andrew STUBBS <andrew.stubbs@st.com>
> 
> +  add_setshow_boolean_cmd ("commandtrace", no_class, &commandtrace, _("\
> +Set tracing of GDB CLI commands."), _("\
> +Show state of GDB CLI command tracing."), _("\
> +When 'on', each command executed is displayed."),

The last sentence will read better if it is rephrased as follows:

  When 'on', each command is displayed as it is executed.

> Index: src/gdb/doc/gdb.texinfo

Thanks.  Please take care of the following gotchas, and then the
documentation patch can go in when the code is approved.

> +Execute @value{GDBN} commands from file @var{file}.

It is better to say

  Execute @value{GDBN} commands from the named @var{file}.

> +If you need to debug user-defined commands or sourced files you may find it
> +useful to enable command tracing. In this mode each command will be printed
                                   ^^
Need two blanks here.

> +If @code{-v}, for verbose mode, is given then then each command will
                                            ^^^^^^^^^
One "then" too much.

> +be displayed as it is executed. The option may be given before or after
                                 ^^
Need two blanks here.