From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13670 invoked by alias); 19 Dec 2005 22:39:46 -0000 Received: (qmail 13663 invoked by uid 22791); 19 Dec 2005 22:39:46 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 19 Dec 2005 22:39:45 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-80-85.inter.net.il [80.230.80.85]) by nitzan.inter.net.il (MOS 3.7.2-GA) with ESMTP id CGF59372 (AUTH halo1); Tue, 20 Dec 2005 00:39:39 +0200 (IST) Date: Wed, 21 Dec 2005 11:25:00 -0000 Message-Id: From: Eli Zaretskii To: Alexandre Oliva CC: gdb-patches@sources.redhat.com In-reply-to: <20051219221830.GA32448@nevyn.them.org> (message from Daniel Jacobowitz on Mon, 19 Dec 2005 17:18:30 -0500) Subject: Re: fixes for type-punning warnings in GCC 4.1 Reply-to: Eli Zaretskii References: <20051219221830.GA32448@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00246.txt.bz2 > Date: Mon, 19 Dec 2005 17:18:30 -0500 > From: Daniel Jacobowitz > Cc: Alexandre Oliva , gdb-patches@sources.redhat.com > > On Tue, Dec 20, 2005 at 12:10:00AM +0200, Eli Zaretskii wrote: > > > From: Alexandre Oliva > > > Date: Mon, 19 Dec 2005 17:20:48 -0200 > > > > > > This patch fixes the type-punning warnings that the GCC 4.1 branch > > > issues when compiling the GDB code base. > > > [...] > > > - num = sscanf (p, "%g%s", (float *) &putithere->typed_val_float.dval,s); > > > + num = sscanf (p, "%g%s", (float *) (void *) &putithere->typed_val_float.dval,s); > > > > If this is the fix, then forgive me, but I'd prefer not to fix it at > > all, 'cause it's so UUUGLYYYY! If we can use some command-line switch > > to GCC to shut it up, let's do that instead. Failing that, let's just > > leave the code alone, so that GCC's continued whining stands as a token > > of our unappreciation to compilers that should have known better! > > I really can't agree; the code GCC's warning about here is pretty > disgusting to start with, and this warning is a very valuable service > of GCC for C conformance. Obviously, Alexandre didn't think it was a valuable service, since he tried to dupe GCC into not providing it ;-) > We should fix it properly, in any case. If we can, let's do it. > The right solution here is pretty apparent: delete the "float" case, > and #define appropriate format characters for DOUBLEST in > doublest.h, in the same place we typedef DOUBLEST. That would be good, yes.