From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-44378-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1085 invoked by alias); 2 Jun 2006 08:13:36 -0000
Received: (qmail 1077 invoked by uid 22791); 2 Jun 2006 08:13:35 -0000
X-Spam-Check-By: sourceware.org
Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 Jun 2006 08:13:34 +0000
Received: from HOME-C4E4A596F7 (IGLD-80-230-33-177.inter.net.il [80.230.33.177]) 	by romy.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id ETR50680 (AUTH halo1); 	Fri, 2 Jun 2006 11:13:30 +0300 (IDT)
Date: Fri, 02 Jun 2006 08:13:00 -0000
Message-Id: <ubqtcdlg3.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Nathan Sidwell <nathan@codesourcery.com>
CC: drow@false.org, gdb-patches@sourceware.org
In-reply-to: <447FE807.6030808@codesourcery.com> (message from Nathan Sidwell 	on Fri, 02 Jun 2006 08:25:59 +0100)
Subject: Re: patch for invalid hw breakpoints
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <447EE9A8.4050800@codesourcery.com> <ulksgeqwz.fsf@gnu.org> <20060601172639.GA25709@nevyn.them.org> <447F27BC.6030808@codesourcery.com> <20060601180321.GA26791@nevyn.them.org> <447FE807.6030808@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-06/txt/msg00015.txt.bz2

> Date: Fri, 02 Jun 2006 08:25:59 +0100
> From: Nathan Sidwell <nathan@codesourcery.com>
> CC: Eli Zaretskii <eliz@gnu.org>,  gdb-patches@sourceware.org
> 
> I suspect that there's actually another failure mode which my patch fixes and it 
> would be hard for remote.c to fix, and that is when the watched expression 
> inserts more than one hardware watchpoint.  The current code will attempt to 
> insert multiple hw watchpoints, and remote.c will signal an internal error on 
> inserting the second one
> 
> -> Z2,11110000
> <- [empty: I don't support that.]
> tries to send: -> Z2,abcdef
> [internal error, I already know I don't support that!]

One more reason not to throw an internal error in remote.c, if you ask
me.  Low-level interfaces have no business doing such things, IMHO.