From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17937 invoked by alias); 9 Jun 2006 19:07:24 -0000 Received: (qmail 17833 invoked by uid 22791); 9 Jun 2006 19:07:22 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Jun 2006 19:07:20 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-209-89.inter.net.il [80.230.209.89]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id DRE22841 (AUTH halo1); Fri, 9 Jun 2006 22:06:34 +0300 (IDT) Date: Fri, 09 Jun 2006 19:07:00 -0000 Message-Id: From: Eli Zaretskii To: Nick Roberts CC: gdb-patches@sources.redhat.com In-reply-to: <17538.8607.697546.427486@kahikatea.snap.net.nz> (message from Nick Roberts on Sun, 4 Jun 2006 11:56:15 +1200) Subject: Re: [PATCH] MI Doco Reply-to: Eli Zaretskii References: <17535.33986.598009.914783@kahikatea.snap.net.nz> <17536.4472.263731.425097@kahikatea.snap.net.nz> <17538.8607.697546.427486@kahikatea.snap.net.nz> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00104.txt.bz2 > From: Nick Roberts > Date: Sun, 4 Jun 2006 11:56:15 +1200 > Cc: gdb-patches@sources.redhat.com > > Here's a patch. Thanks; comments below. You can commit after you take care of them. > ! For the developers convenience CLI commands can be entered directly. "entered directly" is not clear. How about this: For developers' convenience, GDB/MI supports CLI commands even without @code{-interpreter-exec}. > ! However, CLI commands that use sequences of commands such @code{source}, > ! @code{commands} will not work I don't understand from this text what will not work. (Please enclose input that would be typed by user in @kbd, btw.) Do you mean if I type "source, commands", it will not work? Or do you mean something else? Also, you are missing "as" after "such", I think. > and commands that result in queries such > ! as pending breakpoints and quitting once execution has started will > ! default to yes. "..commands that query the user will behave as if the user replied yes." > ! target. This is only present when GDB's event loop Please use @value{GDBN} instead a literal "GDB". > is truely asynchronous which is currently only the case for remote targets. You mean "truly", I think. Also, there should be a comma after "asynchronous". > + @smallexample > + -> -break-insert main > + <- ^done,bkpt=@{number="1",type="breakpoint",disp="keep", > + enabled="y",addr="0x08048564",func="main",file="myprog.c", > + fullname="/home/nickrob/myprog.c",line="68",times="0"@} > + <- (gdb) Please use "(@value{GDBP})" instead of a literal "(gdb)". > + not been implemented yet and these are labelled N.A.@: (not available). ^^^^^^^^ "labeled" > ! Executes one machine instruction. If the instruction is a function > ! call continues until the function returns. If the program stops at an ^ A comma needed here. > + @subheading @value{GDBN} Command > + > + The corresponding @value{GDBN} command is @samp{set inferior-tty /dev/pts/1}. I think you should have only "set inferior-tty" in the @samp, the argument is just an example of the command's usage, and thus doesn't belong here.