From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12284 invoked by alias); 12 Aug 2008 19:08:39 -0000 Received: (qmail 12271 invoked by uid 22791); 12 Aug 2008 19:08:38 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout2.012.net.il (HELO mtaout2.012.net.il) (84.95.2.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Aug 2008 19:07:59 +0000 Received: from HOME-C4E4A596F7 ([84.229.211.50]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K5I00HZK55SORH1@i_mtaout2.012.net.il> for gdb-patches@sourceware.org; Tue, 12 Aug 2008 22:08:17 +0300 (IDT) Date: Tue, 12 Aug 2008 19:08:00 -0000 From: Eli Zaretskii Subject: Re: add file I/O support when debugging an embedded target via jtag In-reply-to: X-012-Sender: halo1@inter.net.il To: Bart Veer Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00325.txt.bz2 > Date: Tue, 12 Aug 2008 17:33:20 +0100 > From: Bart Veer > > +When set, if the target halts at a well-defined location GDB\n\ ^ Need a comma here. > +will treat that as a request for file I/O. The request will be\n\ ^^ Please use two spaces after a period that ends a sentence. > +@node Hardware Debug Support > +@section Extra support for hardware debuggers > + > +@cindex hwdebug This isn't a useful index entry for the Concept Index. The entries in that index are supposed to be phrases, not command names. The latter are introduced by @kindex. How about @cindex hardware debuggers support @kindex hwdebug > +When @value{GDBN} interacts with a server or stub running on the > +remote target the target-side application can perform a number of ^ Missing comma. > +host-side file I/O operations, @xref{File-I/O Remote Protocol @xref should not be in the middle of a sentence, because it produces "See" with a capital S. Please either use "see @ref" or replace the preceding comma with a period. > +or BDM. If so then target-side code may be unable to generate the ^ Missing comma. > +remote protocol messages directly. Instead it can send the request by ^ Missing comma > Instead it can send the request by > +triggering a breakpoint or processor exception at a well-known > +location @code{_gdb_hwdebug_break}. Sorry, I'm not sure I understand this sentence. Are you saying that _gdb_hwdebug_break is a name of a location? If so, please say something like by triggering a breakpoint or processor exception at a well-known location named @code{_gdb_hwdebug_break}. > +default, allowing the application to run stand-alone as well as inside > +a debug session. It can be enabled by a @kbd{set hwdebug} command, or > +disabled by @kbd{set hwdebug off}. ^^^^^^^^^^^ Shouldn't this be "set hwdebug on"? > +Exact usage depends on the application being debugged. Amongst other > +things @kbd{set hwdebug} clears a flag @code{_gdb_hwdebug_disabled} on ^ Missing comma. > +the target. If the application is loaded into RAM then there are no ^ Missing comma. > +problems. However if it is programmed into flash and restarted from ^ Missing comma. > +the reset vector inside the debug session then typically the ^ Missing comma. > +target-side initialization code will reset the disabled flag to its > +default state, undoing the effect of @kbd{set hwdebug}. Instead it ^ Missing comma. > +will be necessary to set a hardware breakpoint at a suitably early > +point in the application startup and invoke @kbd{set hwdebug} when > +that breakpoint is hit. > + > +The target-side API for accessing the h/w debug file I/O functionality ^^^ Please don't use shorthand in the manual. Please use full words. > +depends on the embedded OS or run-time being used. If the > +functionality has not yet been ported then a reference implementation ^ Missing comma. Otherwise, the doco part is okay with me, assuming that the code is approved. Thanks!