Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] MI non-stop and multiprocess docs.
Date: Thu, 13 Nov 2008 04:15:00 -0000	[thread overview]
Message-ID: <ubpwkpsbk.fsf@gnu.org> (raw)
In-Reply-To: <200811122320.28714.vladimir@codesourcery.com>

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Wed, 12 Nov 2008 23:20:28 +0300
> Cc: gdb-patches@sources.redhat.com
> 
> > > > Finally, this chapter seems to be not on design of MI, but more about
> > > > advice to frontend implementors.  So I think it should be renamed
> > > > accordingly, and some introductory text added to its beginning saying
> > > > this is the intent of the chapter.
> > > 
> > > I don't quite agree. These section describes the main building blocks and 
> > > concepts of GDB/MI, and is necessary to understand anything in GDB/MI
> > > docs.
> > 
> > Right, but IMO that isn't "MI design", either.
> 
> Ok, what title would you suggest?

"General Aspects of Interacting with GDB/MI"?

> > > I think they are very similar from frontend point of view -- in that frontend
> > > does only minimal processing of those notification, and won't break if they
> > > are not emitted.
> > 
> > That's okay, but it looks to me that after listing 3 items, it is best
> > to have 3 @items, not 2.
> 
> I'm confused. There are 3 @items in that @itemize block. What change do you
> want to me do?

Never mind, the last revision is OK.

> > > > > +that even commands that operate on global state (like global
> > > > > +variables, or breakpoints), still access the target in the context of
> > > > > +a specific thread
> > > > 
> > > > What do you mean by "global variables" here?  As written, the text
> > > > seems to say that global variables and breakpoints are commands, or
> > > > maybe global state, which doesn't sound right to me.  "Breakpoints"
> > > > could be replaced with "breakpoint commands", but I don't know what
> > > > replacement to suggest for "global variables".
> > > 
> > > global variables, and breakpoints, are examples of the "global state"
> > > that GDB commands can operate on.
> > 
> > What GDB commands operate on global variables?
> 
> Say, 'print' and 'set' can operate on global variables.

Then how about

  even commands that operate on global state, such as @code{print},
  @code{set}, and breakpoint commands, still access the target in the
  context of a specific thread.

> > The new version is fine, except that there are still instances of only
> > one space after a period that ends a sentence.
> 
> I've just went though MI section with a regexp, fixing this issue.

Thanks.  One instance still got through:

> +To allow the user to discover such grouping, and to support arbitrary
> +hierarchy of machines/cores/processes, MI introduces the concept of a
> +@dfn{thread group}.  Thread group is a collection of threads and other
> +thread groups. A thread group always has a string identifier, a type,
                ^^^


  reply	other threads:[~2008-11-12 21:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04 19:15 Vladimir Prus
2008-11-04 21:22 ` Eli Zaretskii
2008-11-08 12:05 ` Eli Zaretskii
2008-11-12 20:37   ` Vladimir Prus
2008-11-12 20:44     ` Eli Zaretskii
2008-11-12 20:47       ` Vladimir Prus
2008-11-13  4:15         ` Eli Zaretskii [this message]
2008-11-13  5:31           ` Vladimir Prus
2008-11-13 13:42             ` Eli Zaretskii
2008-11-13 19:27               ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ubpwkpsbk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox