From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11828 invoked by alias); 13 Mar 2009 09:46:09 -0000 Received: (qmail 11669 invoked by uid 22791); 13 Mar 2009 09:46:07 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Mar 2009 09:45:33 +0000 Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KGF00K00V3CC900@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Fri, 13 Mar 2009 11:45:41 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.127.228.91]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KGF007RVV44KX40@i-mtaout7.012.net.il>; Fri, 13 Mar 2009 11:45:41 +0200 (IST) Date: Fri, 13 Mar 2009 09:53:00 -0000 From: Eli Zaretskii Subject: Re: [RFC] disassemble-next-line In-reply-to: To: teawater Cc: tromey@redhat.com, dje@google.com, pedro@codesourcery.com, drow@false.org, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00199.txt.bz2 > Date: Fri, 13 Mar 2009 07:55:59 +0800 > From: teawater > Cc: Pedro Alves , Daniel Jacobowitz , > "gdb-patches@sourceware.org" > > + add_setshow_enum_cmd ("disassemble-next-line", class_run, > + disassemble_next_line_enum, > + &disassemble_next_line, _("\ > +Set debugger's willingness to use disassemble-next-line."), _("\ > +Show debugger's willingness to use disassemble-next-line."), _("\ This self-referential doc string is confusing. I suggest to change to something like this: Set whether to disassemble next source line when execution stops. and similarly for Show. > +If ON, GDB will disassemble the next source line when execution\n\ > +stops.\n\ If ON, GDB will display disassembly of the next source line when\n\ execution of the program being debugged stops.\n\ > +If AUTO (which is the default) or the next source line cannot be\n\ > +ascertained, the next instruction will be disassembled instead."), What does it mean ``the next source line cannot be ascertained''? In any case, instead of ``the next instruction will be disassembled instead'', I suggest ``display disassembly of the next instruction instead.''