From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17072 invoked by alias); 17 Feb 2006 09:15:04 -0000 Received: (qmail 17057 invoked by uid 22791); 17 Feb 2006 09:15:03 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Feb 2006 09:15:02 +0000 Received: from HOME-C4E4A596F7 (IGLD-83-130-203-69.inter.net.il [83.130.203.69]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id DOV23787 (AUTH halo1); Fri, 17 Feb 2006 11:14:55 +0200 (IST) Date: Fri, 17 Feb 2006 09:15:00 -0000 Message-Id: From: Eli Zaretskii To: fnf@diveadx.com CC: drow@false.org, jimb@red-bean.com, gdb-patches@sourceware.org In-reply-to: <200602161916.00761.fnf@diveadx.com> (message from Fred Fish on Thu, 16 Feb 2006 19:16:00 -0500) Subject: Re: [PATCH] Fix ptype problem printing typedefs defined differently in different compilation units Reply-to: Eli Zaretskii References: <200601031517.50309.fnf@specifix.com> <200602121349.07257.fnf@specifix.com> <20060214141056.GB21812@nevyn.them.org> <200602161916.00761.fnf@diveadx.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00335.txt.bz2 > From: Fred Fish > Date: Thu, 16 Feb 2006 19:16:00 -0500 > Cc: Jim Blandy , gdb-patches@sourceware.org > > On Tuesday 14 February 2006 09:10, Daniel Jacobowitz wrote: > > This patch seems OK to me; but we really ought to fix up the comment > > directly above this code that you're changing. > > I've think it would be best to split work on this issue up into two parts > > (1) Make ptype and whatis handle the same arguments. Currently ptype > will work on typedefs, but whatis does not. This is the change that > makes them both use whatis_exp and eliminates ptype_eval. > [...] > Here is the patch for (1). > [...] > --- 180,191 ---- > whatis_exp (exp, -1); > } > > /* TYPENAME is either the name of a type, or an expression. */ > > static void > ptype_command (char *typename, int from_tty) > { > ! whatis_exp (typename, 1); > } Will the manual's description of the differences between these two commands be still valid after this change?