From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-54090-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31552 invoked by alias); 14 Feb 2008 19:54:03 -0000
Received: (qmail 31541 invoked by uid 22791); 14 Feb 2008 19:54:03 -0000
X-Spam-Check-By: sourceware.org
Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Feb 2008 19:53:43 +0000
Received: from HOME-C4E4A596F7 (IGLD-83-130-247-140.inter.net.il [83.130.247.140]) 	by romy.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id KFQ29669 (AUTH halo1); 	Thu, 14 Feb 2008 21:53:19 +0200 (IST)
Date: Thu, 14 Feb 2008 19:54:00 -0000
Message-Id: <uabm3jow0.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: dje@google.com (Doug Evans)
CC: gdb-patches@sourceware.org, pkoning@equallogic.com
In-reply-to: <20080214021915.F3FE51C72F0@localhost> (dje@google.com)
Subject: Re: [RFA] new command to search memory
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <20080214021915.F3FE51C72F0@localhost>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-02/txt/msg00236.txt.bz2

> Date: Wed, 13 Feb 2008 18:19:15 -0800 (PST)
> From: dje@google.com (Doug Evans)
> 
> I didn't get a response to the non-doc portions of this patch.
> [Eli, thanks for the doc review, I made the suggested changes,
> though I went a different route in shortening the length of the
> line specifying the find command syntax.  The end result is still
> rather short.]

You mean, rather long...

The patch is okay with me, but could you (or someone else) please see
whether these two long lines

> +@item find @r{[}/@var{sn}@r{]} @var{start_addr}, @@@var{len}, @var{val1} @r{[}, @var{val2}, @dots{}@r{]}
> +@itemx find @r{[}/@var{sn}@r{]} @var{start_addr}, @var{end_addr}, @var{val1} @r{[}, @var{val2}, @dots{}@r{]}

survive the typesetting for the printed manual (either by TeX or
pdftex) without overflowing the page margin?  I'm afraid they will
overflow, since the items of this table are typeset with @code, and
@code specifies a chunk of monospaced font that cannot be broken
between lines.