From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3712 invoked by alias); 15 Mar 2008 15:10:46 -0000 Received: (qmail 3702 invoked by uid 22791); 15 Mar 2008 15:10:45 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout6.012.net.il (HELO mtaout6.012.net.il) (84.95.2.16) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 15 Mar 2008 15:10:26 +0000 Received: from HOME-C4E4A596F7 ([84.229.216.171]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0JXS00D9X2QMZSE0@i-mtaout6.012.net.il> for gdb-patches@sources.redhat.com; Sat, 15 Mar 2008 17:23:11 +0200 (IST) Date: Sat, 15 Mar 2008 15:10:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] Keep breakpoints always inserted. In-reply-to: <200803151312.15051.vladimir@codesourcery.com> X-012-Sender: halo1@inter.net.il To: Vladimir Prus Cc: drow@false.org, gdb-patches@sources.redhat.com Reply-to: Eli Zaretskii Message-id: Content-transfer-encoding: 7BIT References: <200802281717.14766.vladimir@codesourcery.com> <20080310210844.GB14908@caradoc.them.org> <200803151312.15051.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00214.txt.bz2 > From: Vladimir Prus > Date: Sat, 15 Mar 2008 13:12:14 +0300 > Cc: gdb-patches@sources.redhat.com > > I've added NEW and documentation. Thanks. > +set breakpoint always-inserted > +show breakpoint always-inserted > + Keep breakpoints always inserted in the target. This entry is not detailed enough to be useful. Please keep in mind that GDB users are not necessarily aware of the fact that GDB removes the breakpoints whenever the inferior stops and reinserts them before resuming it. > +By default, @value{GDBN} inserts breakpoints in the target only when > +resuming the target, and removes breakpoints whenever the target stop. ^^^^ "stops". > +This behaviour guards against leaving breakpoints inserted in the > +target should gdb abrubptly disconnect, which is possible with remote > +targets. Without explaining that a breakpoint replaces a portion of code with a breakpoint instruction, the reader will not understand what is dangerous about this. > This bevaious can be controlled with the following ^^^^^^^^ You mean "behavior", right? > +This is the default behaviour. All breakpoints, including newly added ^^^^^^^^^ Please use the US spelling ("behavior"), for consistency. > +@item set breakpoint always-inserted on > +Causes all breakpoints to be inserted in the target at all times. If > +the user adds a new breakpoint, or changes an existing breakpoint, the > +breakpoints in the target are updated immediately. A breakpoint is > +removed from the target only when breakpoint itself is removed. It would be good to give the reader a hint when this behavior is useful. Otherwise, okay with me.