From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8951 invoked by alias); 2 May 2008 10:17:35 -0000 Received: (qmail 8939 invoked by uid 22791); 2 May 2008 10:17:34 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout3.012.net.il (HELO mtaout3.012.net.il) (84.95.2.7) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 May 2008 10:17:06 +0000 Received: from HOME-C4E4A596F7 ([84.229.228.217]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K0800E1RL8BMVP9@i_mtaout3.012.net.il> for gdb-patches@sourceware.org; Fri, 02 May 2008 13:31:24 +0300 (IDT) Date: Fri, 02 May 2008 10:17:00 -0000 From: Eli Zaretskii Subject: Re: RFC: Use the ARM CPSR as a fallback to determine ARM/Thumb In-reply-to: <20080501183805.GA22218@caradoc.them.org> X-012-Sender: halo1@inter.net.il To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <20060220214918.GA28798@nevyn.them.org> <1140519913.27380.29.camel@pc960.cambridge.arm.com> <20060221153601.GA21183@nevyn.them.org> <20060302221446.GA18830@nevyn.them.org> <20080501183805.GA22218@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00063.txt.bz2 > Date: Thu, 1 May 2008 14:38:05 -0400 > From: Daniel Jacobowitz > Cc: Eli Zaretskii > > Eli, do the documentation and NEWS changes look OK? Yes, but I have a few comments: > +@item set arm fallback-mode > +This command sets the mode (ARM versus Thumb) which @value{GDBN} will > +assume for code without a symbol table. The default is @samp{auto}, > +which causes @value{GDBN} to use the mode associated with the current > +CPSR. Please explain (in parens or in a @footnote) what is CPSR. There's no other instance in the manual where this acronym is used. Also, I think we should list all possible values of this option explicitly. As written, the text forces the user to gather the values incrementally (first ARM and Thumb, then auto), and leaves me wondering whether there are more possible values. > +set arm fallback-mode (arm|thumb|auto) > +show arm fallback-mode > +set arm force-mode (arm|thumb|auto) > +show arm force-mode > + These variables control how ARM GDB determines whether instructions ^^^^^^^^^ "commands", not "variables", I think. > + are ARM or Thumb. The default for both settings is auto, which uses > + the current CPSR value for instructions without symbols; previous > + versions of GDB behaved as if "set arm fallback-mode arm". Btw, I find this description much better than the one in gdb.texinfo: here you explicitly talk about instructions, whereas in the manual the description is much more abstract and doesn't even mention instructions. Can we make the manual closer to NEWS in this sense? Thanks.