From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61173-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12681 invoked by alias); 15 Jan 2009 04:21:32 -0000
Received: (qmail 12667 invoked by uid 22791); 15 Jan 2009 04:21:31 -0000
X-SWARE-Spam-Status: No, hits=3.0 required=5.0 	tests=AWL,BAYES_20,BOTNET,J_CHICKENPOX_37,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Jan 2009 04:20:34 +0000
Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KDH00E00VUP4M00@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Thu, 15 Jan 2009 06:20:42 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.127.202.36]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KDH00IGPW2HG970@i-mtaout1.012.net.il>; Thu, 15 Jan 2009 06:20:42 +0200 (IST)
Date: Thu, 15 Jan 2009 04:21:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Use external editor in 'commands' command
In-reply-to: <e598931c0901141632m4f124d85l2452f7e2870cad91@mail.gmail.com>
To: Alfredo Ortega <ortegaalfredo@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uab9tw67k.fsf@gnu.org>
References: <e598931c0901141343j79164cf6we2bc5307f41f41da@mail.gmail.com> <e598931c0901141347j4d159f16he23ad164760518ff@mail.gmail.com> <ueiz5wm3n.fsf@gnu.org> <e598931c0901141632m4f124d85l2452f7e2870cad91@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-01/txt/msg00343.txt.bz2

> Date: Wed, 14 Jan 2009 22:32:03 -0200
> From: Alfredo Ortega <ortegaalfredo@gmail.com>
> 
> I see. This updated patch contains my proposed documentation changes
> to gdb.texinfo and refcard.tex. I hope that the patch format is
> adequate.

Thanks you.

First, please also submit ChangeLog entries for your changes, both in
code and in documentation.

> +@item commands @r{[}@var{bnum}@r{]} edit
> +This spawns an external editor for adding or editing commands. the final  @code{end} is not necessary in this case. @xref{Choosing your Editor}.
                                                                  ^^^
Capital "T" here.

Also, please leave 2 blanks after a period that ends a sentence.

> +@node Choosing your Editor
>  @subsection Choosing your Editor

Adding a @node requires that you also modify the @menu in its parent
node, otherwise makeinfo will barf.

> +\qquad {\it command-list}&execute GDB {\it command-list} every time breakpoint {\it n} is reached. \opt{{\tt silent} suppresses default display}  \opt{{\tt edit} use external editor for commands}
                                                                   ^^^
A period missing here.