From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7197 invoked by alias); 8 Jun 2005 14:52:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7168 invoked by uid 22791); 8 Jun 2005 14:52:43 -0000 Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 08 Jun 2005 14:52:43 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-228-238-226.inter.net.il [84.228.238.226]) by romy.inter.net.il (MOS 3.5.8-GR) with ESMTP id BMC42227 (AUTH halo1); Wed, 8 Jun 2005 17:52:13 +0300 (IDT) Date: Wed, 08 Jun 2005 14:52:00 -0000 Message-Id: From: Eli Zaretskii To: Jason Molenda CC: gdb-patches@sources.redhat.com, kettenis@jive.nl In-reply-to: <85C775AE-3B05-431E-96D2-49EA9D1413E6@apple.com> (message from Jason Molenda on Tue, 7 Jun 2005 22:51:36 -0700) Subject: Re: The gdb x86 function prologue parser Reply-to: Eli Zaretskii References: <85C775AE-3B05-431E-96D2-49EA9D1413E6@apple.com> X-SW-Source: 2005-06/txt/msg00063.txt.bz2 > Cc: Mark Kettenis > From: Jason Molenda > Date: Tue, 7 Jun 2005 22:51:36 -0700 > > I can't even begin to imagine how annoyed developers using the FSF > gdb on x86 must be. Well, I'm one of the annoyed, although I have no idea whether the problems that annoyed me would be solved by your patches. In any case, thanks. > --- i386-tdep.c 28 May 2005 16:44:28 -0000 1.213 > +++ i386-tdep.c 8 Jun 2005 05:24:14 -0000 > @@ -21,6 +21,7 @@ > Foundation, Inc., 59 Temple Place - Suite 330, > Boston, MA 02111-1307, USA. */ > > +#include I don't think we can use stdint.h freely, as we still don't require a C9x compiler. I see you needed it for things like uint8_t and uint32_t, which should be easily replaceable by suitable standard x86 types. I also agree with Daniel: it would be nice to find a more graceful way of storing knowledge about so many instructions. Last, but not least, I'd surely appreciate some write-up, even in plain ASCII, about how prologue analyzers in general and the x86 one in particular work: that stuff is sorely needed in gdbint.texinfo. TIA