From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14111 invoked by alias); 10 Dec 2005 09:57:43 -0000 Received: (qmail 14103 invoked by uid 22791); 10 Dec 2005 09:57:42 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 10 Dec 2005 09:57:42 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-42-206.inter.net.il [80.230.42.206]) by romy.inter.net.il (MOS 3.7.2-GA) with ESMTP id DDL34746 (AUTH halo1); Sat, 10 Dec 2005 11:57:31 +0200 (IST) Date: Sun, 11 Dec 2005 23:40:00 -0000 Message-Id: From: Eli Zaretskii To: Wu Zhou CC: drow@false.org, gdb-patches@sources.redhat.com, Thomas.Koenig@online.de In-reply-to: (message from Wu Zhou on Sat, 10 Dec 2005 15:24:29 +0800 (CST)) Subject: Re: [RFC]: Patch to support Fortran derived type - Revised Reply-to: Eli Zaretskii References: <20051207232541.GB7483@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00200.txt.bz2 > Date: Sat, 10 Dec 2005 15:24:29 +0800 (CST) > From: Wu Zhou > cc: gdb-patches@sources.redhat.com, Thomas.Koenig@online.de > > Here is the revised patch, testcase and documents. Thanks. My comments about the documentation patch are below. > 2005-12-10 Wu Zhou > > * gdb.texinfo (Fortran): Document the "%" operator for member > access. > (Fortran): Document the type-print and value-print operation of > Fortran 90 derived types. These two entries reference the same node "Fortran", so there's no need to mention the node twice. Just write the two sentences one after the other; you don't even need a newline between them. > + @item % > + ortran 90 and afterwards use this to access the members of derived ^^^^^^ A typo. Also, I'd prefer "and later" instead of "and afterwards". > + @cindex Structure type-print Index entries by convention should begin with a lower-case letter. > + Fortran 90 and afterwards support derived type (a.k.a structure). For ^^^^^^^^^^^^^^ "and later" > + a variable of derived type, ptype command will output all its members, ^^^^^ Please give each command the @code markup: @code{ptype}. Actually, "the @code{ptype} command" is more correct English, I think. > + @noindent > + ptype commands give this output: ^^^^^^^^^^^^^^ "the @code{ptype} commands" > + @end smallexample > + > + @noindent > + This @noindent looks unnecessary to me. Why did you add it? > + @cindex Structure value-print Again, please begin all index entries with a lower-case letter. > + @item print @var{derived-type} > + For a variable of derived type, print command will output the value of ^^^^^^^^^^^^^ "the @code{print} command" > + For example, for variable q of type foo defined above: `q' and `foo' are Fortran symbols, so both of them should have the @code markup: "for a variable @code{q} of type @code{foo} defined above". > + @noindent > + print command will output this: ^^^^^^^^^^^^^ "the @code{print} command" > + $1 = @{ 3.125, @{ 1, 2.375@}, (97 'a', 98 'b', 99 'c', 100 'd', 101 'e', 102 'f', 103 'g')@} This is too long for a single line (TeX will not break lines inside @smallexample). Please break it into 2 lines, and please add text saying that it's a single long line, broken only for clarity.