From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-52161-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10856 invoked by alias); 13 Nov 2007 22:30:14 -0000
Received: (qmail 10848 invoked by uid 22791); 13 Nov 2007 22:30:13 -0000
X-Spam-Check-By: sourceware.org
Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (213.8.233.22)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Nov 2007 22:29:41 +0000
Received: from HOME-C4E4A596F7 (IGLD-80-230-17-184.inter.net.il [80.230.17.184]) 	by nitzan.inter.net.il (MOS 3.7.3a-GA) 	with ESMTP id IHW70561 (AUTH halo1); 	Wed, 14 Nov 2007 00:26:57 +0200 (IST)
Date: Tue, 13 Nov 2007 22:30:00 -0000
Message-Id: <u8x51eq40.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: luisgpm@linux.vnet.ibm.com
CC: drow@false.org, gdb-patches@sourceware.org
In-reply-to: <1194961811.4820.3.camel@localhost> (message from Luis Machado on 	Tue, 13 Nov 2007 11:50:11 -0200)
Subject: Re: [patch] Watchpoints: support for thread <thread_num> parameters
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <1187298178.5853.11.camel@localhost> <uwsvuv4re.fsf@gnu.org> 	 <1187365616.4520.14.camel@localhost> 	 <20071011193558.GE30810@caradoc.them.org> 	 <1192134591.18528.1.camel@localhost> <1194961811.4820.3.camel@localhost>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-11/txt/msg00257.txt.bz2

> From: Luis Machado <luisgpm@linux.vnet.ibm.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
> Date: Tue, 13 Nov 2007 11:50:11 -0200
> 
> Here is the patch together with the testcase and the documentation bits.

Thanks!

> Please let me know if there are any improvements/corrections suitable
> for this one.

The documentation part is okay with me, provided that you fix the
following two small gotchas:

> +@item watch @var{expr} thread thread_num

thread_num should be in @var here.  Also, I'd suggest to use threadnum
or just num, to avoid the underscore (that doesn't go well together
with the @var markup).

> +Set a watchpoint that will break when @var{expr} is either read from
> +or written into by the thread identified by @var{thread_num}. If @var{expr}
                                                               ^^
> +is modified by any other threads not matching @var{thread_num}, @value{GDBN}
> +will not break. Note that this will only work with Hardware Watchpoints.
                 ^^
Two spaces after a period that ends a sentence, please.