From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30818 invoked by alias); 16 Oct 2008 08:13:14 -0000 Received: (qmail 30810 invoked by uid 22791); 16 Oct 2008 08:13:13 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout3.012.net.il (HELO mtaout3.012.net.il) (84.95.2.7) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Oct 2008 08:12:34 +0000 Received: from HOME-C4E4A596F7 ([77.127.24.3]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K8T00KFEO75TDD2@i_mtaout3.012.net.il> for gdb-patches@sourceware.org; Thu, 16 Oct 2008 10:13:54 +0200 (IST) Date: Thu, 16 Oct 2008 08:13:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] Displaced stepping just enable in non-stop mode In-reply-to: <200810160107.42525.pedro@codesourcery.com> X-012-Sender: halo1@inter.net.il To: Pedro Alves Cc: teawater@gmail.com, gdb-patches@sourceware.org, brobecker@adacore.com, msnyder@vmware.com Reply-to: Eli Zaretskii Message-id: References: <200810160107.42525.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00399.txt.bz2 > From: Pedro Alves > Date: Thu, 16 Oct 2008 01:07:42 +0100 > Cc: gdb-patches@sourceware.org, > "Joel Brobecker" , > "Michael Snyder" > > Eli, can I ask you to go over the help strings and the documentation in > the patch below? Do they look OK-ish? They are OK, but: . The doc strings use too long lines, which will look ugly on your garden-variety 80-column terminal. . In the gdb.texinfo, don't put "set" and "show" commands in the same @item/@itemx, because the text below them says "Control whether...", which is inappropriate for the "show" command. . "Displaced stepping" is really a bad name for this feature. Is it widely accepted or did we invent it? . This text: +@cindex non-stop mode, and @samp{set can-use-displaced-stepping} +@item set can-use-displaced-stepping auto +This is the default mode. @value{GDBN} will use displaced stepping +only if non-stop mode is active (@pxref{Non-Stop Mode}) and the target +architecture supports it. needs to be rephrased in the last sentence, to disambiguate the "supports it" part: a reader could be confused to think that "it" refers to the non-stop mode, not to displaced stepping. . Why isn't it better to use displaced stepping, if supported, even if non-stop mode is not in effect? I think the linkage between the two is confusing and unnecessary. . I agree with Daniel's criticism of the can-use-displaced-stepping option's name. An obvious first step towards making it shorter would be to remove the "can-" prefix. Thanks.