From: Andreas Jaeger <aj@suse.de>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: Jiri Smid <smid@suse.cz>,
gdb-patches@sources.redhat.com, Michal Ludvig <mludvig@suse.cz>
Subject: Re: [RFA] x86-64 target bugfixes 3
Date: Sun, 20 Jan 2002 01:30:00 -0000 [thread overview]
Message-ID: <u8vgdxtlpt.fsf@gromit.moeb> (raw)
In-Reply-To: <3C49B218.7020900@cygnus.com> (Andrew Cagney's message of "Sat, 19 Jan 2002 12:51:20 -0500")
Andrew Cagney <ac131313@cygnus.com> writes:
>> Index: ChangeLog
>> from Jiri Smid <smid@suse.cz>
>> * x86-64linux.mh (NATDEPFILES): x86-64-nat.o removed.
>> * x86-64-linux-nat.c (x86_64_register_u_addr): New function.
>> * nm-x86-64.h (ATTACH_LWP): Removed.
>> * Makefile.in (x86-64-tdep.o, x86-64-linux-tdep.o,
>> x86-64-linux-nat.o): Fix dependencies.
>> * xm-i386.h (solib.h): Include.
>>
>
>
> Jiri, I suspect several people looked around and then assumed another
> person was handling this change :-( Sorry.
>
> One cosmetic tweek for the ChangeLog. x86-64linux.mh et.al. should
> read config/i386/x86-64linux.mh et.al. - the full path to files in sub
> directories is needed.
>
> Everything is fine except the tweek to xm-i386.h. The xm file is for
> host configury, not native configury. I suspect you ment to add it to
> config/i386/nm-<something>.h.
I left this patch out, since nm-x86-64.h contains those lines already.
I committed the rest and adjusted the copyright year also,
Andrew, Thanks for the review,
Andreas
* config/i386/x86-64linux.mh (NATDEPFILES): x86-64-nat.o removed.
* x86-64-linux-nat.c (x86_64_register_u_addr): New function.
* config/i386/nm-x86-64.h (ATTACH_LWP): Removed.
* Makefile.in (x86-64-tdep.o, x86-64-linux-tdep.o,
x86-64-linux-nat.o): Fix dependencies.
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj
prev parent reply other threads:[~2002-01-20 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-20 1:04 Jiri Smid
2002-01-19 9:51 ` Andrew Cagney
2002-01-20 1:30 ` Andreas Jaeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u8vgdxtlpt.fsf@gromit.moeb \
--to=aj@suse.de \
--cc=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mludvig@suse.cz \
--cc=smid@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox